Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect caller's custom weight limit setting in XVM #987

Closed
shaunxw opened this issue Jul 27, 2023 · 2 comments
Closed

Respect caller's custom weight limit setting in XVM #987

shaunxw opened this issue Jul 27, 2023 · 2 comments
Assignees
Labels
project Issue is part of an ongoing project XVM Related to XVM

Comments

@shaunxw
Copy link
Member

shaunxw commented Jul 27, 2023

Thinking about this, both EVM & Parity's WASM allow limiting of how much gas can be spent by the cross-contract call. We should also support this, I guess?

Not necessarily for this PR, but would be good to do in a follow-up.

Originally posted by @Dinonard in #980 (comment)

@shaunxw shaunxw self-assigned this Jul 27, 2023
@shaunxw shaunxw added the XVM Related to XVM label Jul 27, 2023
@shaunxw shaunxw mentioned this issue Jul 27, 2023
5 tasks
@shaunxw shaunxw changed the title Allow to set max weight can be used for XVM call Respect caller's custom weight limit setting in XVM Aug 11, 2023
@shaunxw
Copy link
Member Author

shaunxw commented Aug 11, 2023

For calls from EVM, the caller's custom gas limit check is implemented in #998 .

For XVM, as discussed in #998 (comment), the solution will be

  1. make ink! env support weight v2; 2. add custom weight support to call_runtime interface. And then add the support for XVM.

@Dinonard Dinonard added the project Issue is part of an ongoing project label Aug 31, 2023
@Dinonard
Copy link
Member

Deprecated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
project Issue is part of an ongoing project XVM Related to XVM
Projects
None yet
Development

No branches or pull requests

2 participants