Merge pull request #124 from AstuteSource/increase-testcoverage

Increase test coverage

Author: laurennevill

tests/test_checks.py

@@ -7,8 +7,10 @@
 
 from chasten.checks import (
     check_match_count,
+    extract_description,
     extract_min_max,
     is_in_closed_interval,
+    make_checks_status_message,
 )
 from chasten.validate import JSON_SCHEMA_CHECKS
 
@@ -59,6 +61,41 @@ def test_extract_min_max_missing():
     assert max_count is None
 
 
+def test_extract_description():
+    """Confirm that if a description exists, it is properly retrieved."""
+    check = {
+        "name": "test",
+        "description": "described test",
+        "count": {
+            "min": 1,
+        },
+    }
+    assert "described test" == extract_description(check)
+
+
+def test_extract_desription_none():
+    """Confirm that if a description does not exist, an empty string is returned."""
+    check = {
+        "name": "test",
+        "count": {
+            "min": 1,
+        },
+    }
+    assert "" == extract_description(check)
+
+
+@pytest.mark.parametrize(
+    "bool_status,expected",
+    [
+        (True, ":smiley: Did the check pass? Yes"),
+        (False, ":worried: Did the check pass? No"),
+    ],
+)
+def test_make_checks_status_message(bool_status: bool, expected: str):
+    """Confirms the output matches the expected message."""
+    assert make_checks_status_message(bool_status) == expected
+
+
 @given(st.dictionaries(st.text(), st.integers()))
 @pytest.mark.fuzz
 def test_extract_min_max_hypothesis(check):
@@ -89,6 +126,8 @@ def test_integers(check):
         (1, None, None, True),
         (5, 6, 4, False),
         (1, 4, 6, False),
+        (1, 2, None, False),
+        (3, None, 2, False),
     ],
 )
 def test_check_match_count_expected(count, min_value, max_value, expected):

tests/test_database.py

@@ -0,0 +1,16 @@
+"""Pytest test suite for the database module."""
+
+import os
+
+from chasten import database
+
+
+def test_create_chasten_view():
+    """Confirm that the function creating and viewing an example database does not crash"""
+    # define the variable name for the example database
+    chasten_database_name: str = ".example_database"
+    # create the database with example name
+    # run the view command with a set SQL query
+    database.create_chasten_view(chasten_database_name)
+    # remove the example variable made
+    os.remove(".example_database")

tests/test_filesystem.py

@@ -25,6 +25,7 @@ def test_invalid_directory() -> None:
     directory = pathlib.Path(directory_str)
     confirmation = filesystem.confirm_valid_directory(directory)
     assert confirmation is False
+    assert filesystem.confirm_valid_directory(None) is False
 
 
 def test_valid_file() -> None:
@@ -41,6 +42,7 @@ def test_invalid_file() -> None:
     this_file_not = pathlib.Path(file_str)
     confirmation = filesystem.confirm_valid_file(this_file_not)
     assert confirmation is False
+    assert filesystem.confirm_valid_file(None) is False
 
 
 @given(directory=strategies.builds(pathlib.Path))