Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Functions::compareStrict and compareLoose with spaceship operator #47

Open
Athari opened this issue Jun 20, 2019 · 0 comments
Open

Replace Functions::compareStrict and compareLoose with spaceship operator #47

Athari opened this issue Jun 20, 2019 · 0 comments
Assignees
@Athari
Labels
type:improvement Improvement
Milestone
3.0

Comments

@Athari
Copy link
Owner

Athari commented Jun 20, 2019

Remove compareStrict and compareLoose functions in Functions. Add compare function which is implemented using spaceship operayor (<=>).

compareStrict is unstable anyway (1 < '1' == false, 1 > '1' == false).
@Athari Athari self-assigned this Jun 20, 2019
@Athari Athari added the type:improvement Improvement label Jun 20, 2019
@Athari Athari added this to the 3.0 milestone Jun 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Athari Athari

Labels
type:improvement Improvement
Projects
None yet
Milestone
3.0
Development

No branches or pull requests
1 participant
@Athari