Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default values should be carefully selected #44

Closed
mlajkim opened this issue Oct 24, 2023 · 1 comment · Fixed by #85
Closed

Default values should be carefully selected #44

mlajkim opened this issue Oct 24, 2023 · 1 comment · Fixed by #85
Labels
enhancement New feature or request

Comments

@mlajkim
Copy link
Contributor

mlajkim commented Oct 24, 2023

Background

Default value like DELETE_INSTANCE_ID=true is wrong as it requires athenz permission and outputting error message without permission isn't the best

TODOs

- [ ] Check the default values
- [ ] Check if every env must be modifiable under Makefile
@WindzCUHK
Copy link
Contributor

Deleting the instance certificate should be the default behavior because of the following:

  • improve security
  • reduce ZTS load

I think the focus should be the error message.

@mlajkim mlajkim added the enhancement New feature or request label Nov 16, 2023
@mlajkim mlajkim linked a pull request Feb 28, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants