From 361be46297a2890c4bd06377eb83d39015b84be3 Mon Sep 17 00:00:00 2001
From: Chris <chris.godwin.ala@gmail.com>
Date: Mon, 27 Nov 2023 14:00:36 +1100
Subject: [PATCH] Support computed select2Many #216

---
 .../javascripts/forms-knockout-bindings.js    |  5 +++-
 .../forms/EditModelWidgetRenderer.groovy      | 28 +++++++++++++------
 2 files changed, 23 insertions(+), 10 deletions(-)

diff --git a/grails-app/assets/javascripts/forms-knockout-bindings.js b/grails-app/assets/javascripts/forms-knockout-bindings.js
index abba7afb..5707d602 100644
--- a/grails-app/assets/javascripts/forms-knockout-bindings.js
+++ b/grails-app/assets/javascripts/forms-knockout-bindings.js
@@ -679,7 +679,10 @@
             var options = _.defaults(valueAccessor() || {}, defaults);
 
             $(element).select2(options).change(function(e) {
-                model($(element).val());
+                if (ko.isWritableObservable(model)) { // Don't try and write the value to a computed.
+                    model($(element).val());
+                }
+
             });
 
             if (options.preserveColumnWidth) {
diff --git a/src/main/groovy/au/org/ala/ecodata/forms/EditModelWidgetRenderer.groovy b/src/main/groovy/au/org/ala/ecodata/forms/EditModelWidgetRenderer.groovy
index a3b44ba3..39cd4a81 100644
--- a/src/main/groovy/au/org/ala/ecodata/forms/EditModelWidgetRenderer.groovy
+++ b/src/main/groovy/au/org/ala/ecodata/forms/EditModelWidgetRenderer.groovy
@@ -134,10 +134,13 @@ public class EditModelWidgetRenderer implements ModelWidgetRenderer {
         context.writer <<  "<div${context.attributes.toString()}><select class=\"select form-control form-control-sm\" data-bind='${context.databindAttrs.toString()}'${context.validationAttr}></select></div>"
     }
 
+    private static boolean isReadOnly(WidgetRenderContext context) {
+        context.model.readonly || context.dataModel.computed
+    }
     @Override
     void renderSelectMany(WidgetRenderContext context) {
 
-        if (context.model.readonly) {
+        if (isReadOnly(context)) {
             renderSelectManyAsString(context)
         }
         else {
@@ -147,16 +150,23 @@ public class EditModelWidgetRenderer implements ModelWidgetRenderer {
 
     @Override
     void renderSelect2Many(WidgetRenderContext context) {
-        context.databindAttrs.add 'options', context.source + '.constraints'
-        context.databindAttrs.add 'optionsValue', context.source + '.constraints.value'
-        context.databindAttrs.add 'optionsText', context.source + '.constraints.text'
 
-        String options = "{value: ${context.source}, tags:true, allowClear:false}"
-        if (context.model.displayOptions) {
-            options = "_.extend({value:${context.source}}, ${context.source}.displayOptions)"
+        if (isReadOnly(context)) {
+            renderSelectManyAsString(context)
+        }
+        else {
+            context.databindAttrs.add 'options', context.source + '.constraints'
+            context.databindAttrs.add 'optionsValue', context.source + '.constraints.value'
+            context.databindAttrs.add 'optionsText', context.source + '.constraints.text'
+
+            String options = "{value: ${context.source}, tags:true, allowClear:false}"
+            if (context.model.displayOptions) {
+                options = "_.extend({value:${context.source}}, ${context.source}.displayOptions)"
+            }
+            context.databindAttrs.add 'multiSelect2', options
+            context.writer <<  "<div${context.attributes.toString()}><select multiple=\"multiple\" class=\"select form-control form-control-sm\" data-bind='${context.databindAttrs.toString()}'${context.validationAttr}></select></div>"
         }
-        context.databindAttrs.add 'multiSelect2', options
-        context.writer <<  "<div${context.attributes.toString()}><select multiple=\"multiple\" class=\"select form-control form-control-sm\" data-bind='${context.databindAttrs.toString()}'${context.validationAttr}></select></div>"
+
     }
 
     @Override