Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python versions #175

Open
dalmouiee opened this issue Dec 24, 2024 · 1 comment
Open

Python versions #175

dalmouiee opened this issue Dec 24, 2024 · 1 comment

Comments

@dalmouiee
Copy link
Member

Hey @pchlap, just wanted to see how we wanted to handle pydicer moving forward with python versions. I think as of now it works for 3.8-3.9 but not anything more recent. I am creating a devcontainer for version 3.9 and make development at least more streamlined that way, but we might want to look at 3.10 and 3..11, and see what needs to be be updated under the hood with pyradiomics, thanks!

@pchlap
Copy link
Contributor

pchlap commented Dec 24, 2024

Hi @dalmouiee, thats for being proactive on this. I agree, it would be great to make sure we can support more recent Python versions.

I do think pyradiomics will be the key (or only) sticking point. I noticed this PR was merged a couple of months back: AIM-Harvard/pyradiomics#836
If I remember correctly then this was the problem we were facing in our poetry builds, but I would need to revisit to confirm. I also think we need to wait for pyradiomics to actually make a 3.1.1 release which they haven't done yet.

I can try to revisit this over the next weeks when I get some time. Or if you have capacity it would be great if we can confirm what the exact issue is/was. Basically I think we just need to add 3.10 and 3.11 back into our Github PR pipelines and see what issues arise. If we are sure the 3.1.1 pyradiomics version is what we need, then we can post on their GitHub to see if there is anything we can do to help get this moving along.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants