Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markup3D Bugfix #6

Open
0x41mmar opened this issue Jan 10, 2018 · 3 comments
Open

Markup3D Bugfix #6

0x41mmar opened this issue Jan 10, 2018 · 3 comments

Comments

@0x41mmar
Copy link

The latest update to Markup3D in this repository, before deprecation, is a bugfix in commit 0fbd12a, but somehow that fix breaks things for me. Everything works until I rotate the view, at which point I get a console error saying t.screenPoint undefined.
I've tried using various versions, but the latest one that works is right before this commit.

Any idea what the issue could be? I'm using viewer version 3.3 (latest, I believe).

@leefsmp
Copy link
Contributor

leefsmp commented Jan 11, 2018

@0x41mmar
Copy link
Author

Tried. Same issue occurs. What I'm doing is quite minimal, just loading bootstrap, jQuery, viewer and the extension, browsing straight from the file system. It seems the only possible source of error is my transpiling, but all I'm doing is an npm install and run build-prod.

@leefsmp
Copy link
Contributor

leefsmp commented Jan 11, 2018

I wrote recently a new markup feature based on PointCloud, which is much more performant when your app needs to handle large number of markups, you can take a look at those articles:

High-Performance 3D markups with PointCloud in the Forge Viewer

Using a Dynamic Texture inside Custom Shaders

The complete code is at:
Viewing.Extension.PointCloudMarkup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants