-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Converted examples to functional. Made compute_backend name consistent. #105
Conversation
62c2fc4
to
6a15554
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move all function defintion in the examples to the top of the file. Then start all the scripts one after another. Right now, functions and scripts are mixed up together.
That is not always possible since we use those calls and values in the following functions. Because this is a script rather than reusable functions, it is completely acceptable to not pass those parameters and instead just use them inside the function. |
It IS a bad practice (and a linting error) to assume those values will be available in "future" calls. Codes must be well defined if read from top. |
please run |
This PR addressed issue #103 |
6a15554
to
d91f8e9
Compare
Pls finish this |
I like the latest changes. Can you please also run |
It does not. make sure to use the correct ruff config (the checks are also passed here, so there should't be an issue). |
~/Repos/XLB/examples$ ruff check . ~/Repos/XLB/examples$ ruff format . There was on extra space that I just pushed. |
d91f8e9
to
50e71ff
Compare
please do |
50e71ff
to
a3f1b17
Compare
Contributing Guidelines
Description
Type of change
How Has This Been Tested?
Linting and Code Formatting
Make sure the code follows the project's linting and formatting standards. This project uses Ruff for linting.
To run Ruff, execute the following command from the root of the repository:
ruff check .