Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: Plugin RequestedBy #66

Open
jezzsantos opened this issue Dec 28, 2015 · 0 comments
Open

Question: Plugin RequestedBy #66

jezzsantos opened this issue Dec 28, 2015 · 0 comments

Comments

@jezzsantos
Copy link
Contributor

I am working on the plugin for AppVeyor, and have a question about design.

When we fetch the status of our builds from the CI server we can get the username and the displayname of the person who committed the build (created the shame). i.e. Display Name: Jezz Santos, Username: jezzsantos

Now, which one should we assign to BuildStatus.RequestedBy ???

This username and displayname are coming from GitHub, because that is where we store the code, and github is what triggers the CI build. However, the username and display name of that person's SoS account may be very different. So my question is: how should we be designing whether to use the committers username or display name??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant