diff --git a/junit5/pom.xml b/junit5/pom.xml index 1e1d06e..5263b26 100644 --- a/junit5/pom.xml +++ b/junit5/pom.xml @@ -63,17 +63,17 @@ <dependency> <groupId>org.seleniumhq.selenium</groupId> <artifactId>selenium-api</artifactId> - <version>3.8.1</version> + <version>3.12.0</version> </dependency> <dependency> <groupId>org.seleniumhq.selenium</groupId> <artifactId>selenium-chrome-driver</artifactId> - <version>3.8.1</version> + <version>3.12.0</version> </dependency> <dependency> <groupId>org.seleniumhq.selenium</groupId> <artifactId>selenium-remote-driver</artifactId> - <version>3.8.1</version> + <version>3.12.0</version> </dependency> <dependency> <groupId>org.seleniumhq.selenium</groupId> diff --git a/testng/pom.xml b/testng/pom.xml index 652a0ad..8b31746 100644 --- a/testng/pom.xml +++ b/testng/pom.xml @@ -48,12 +48,12 @@ <dependency> <groupId>org.seleniumhq.selenium</groupId> <artifactId>selenium-chrome-driver</artifactId> - <version>3.8.1</version> + <version>3.12.0</version> </dependency> <dependency> <groupId>org.seleniumhq.selenium</groupId> <artifactId>selenium-api</artifactId> - <version>3.8.1</version> + <version>3.12.0</version> </dependency> <dependency> <groupId>org.testng</groupId> diff --git a/testng/src/main/java/com/github/automatedowl/tools/JSErrorsCollectorListener.java b/testng/src/main/java/com/github/automatedowl/tools/JSErrorsCollectorListener.java index b41cce8..ca616b6 100644 --- a/testng/src/main/java/com/github/automatedowl/tools/JSErrorsCollectorListener.java +++ b/testng/src/main/java/com/github/automatedowl/tools/JSErrorsCollectorListener.java @@ -63,8 +63,8 @@ public void afterInvocation(IInvokedMethod iInvokedMethod, ITestResult iTestResu } else if (isAssertJSErrorsEnabled( iInvokedMethod) && getJSErrorsFromLogEntries(logEntries).anyMatch(e -> true)) { - JSErrorsDriverHolder.getDriverForTest(iInvokedMethod.getTestMethod().getMethodName()).quit(); - throw new WebDriverException(JS_ERRORS_EXCEPTION_STRING); + logger.severe(JS_ERRORS_EXCEPTION_STRING); + iTestResult.setStatus(ITestResult.FAILURE); } } }