-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jetpack Submenu Icons Don't Open New Window #32601
Comments
Related: https://github.com/Automattic/jetpack-scan-team/issues/792 Also on P2: p1HpG7-qtT-p2 |
Support References This comment is automatically generated. Please do not edit it.
|
This issue has been marked as stale. This happened because:
No further action is needed. But it's worth checking if this ticket has clear reproduction steps and it is still reproducible. Feel free to close this issue if you think it's not valid anymore — if you do, please add a brief explanation. |
If a link points to a site within our trusted network (Calypso, wp-admin, Jetpack, A4A) we should not be showing these icons. |
@davemart-in Would you mind sharing the reasoning behind that opinion? |
We did a full audit of external links and came up with these rules as a result of our observations:
Here are a few links with additional context:
|
Thanks @davemart-in, will add a comment of the latest post. |
Left a comment here: pekYwv-4Jd-p2#comment-4304 |
Impacted plugin
Jetpack
What
When looking at the Jetpack Submenu items that indicate a new window will be opened, they don't actually open a new window.
How
Surfaced during internal testing: p8oabR-1jo-p2#comment-7542
Some submenu items like Subscribers and Scan don't open the window in a new tab. I believe we're using this indicator because the link goes outside of the WP Site (to cloud.jetpack.com in the case of Scan), but it opens in the same time.
The text was updated successfully, but these errors were encountered: