Remove QIT development tools and simplify E2E test setup for WooCommerce Payments

Author: mgascam

includes/class-wc-payments.php

@@ -792,20 +792,6 @@ function () {
 		add_action( 'wp_enqueue_scripts', [ __CLASS__, 'enqueue_cart_scripts' ] );
 
 		// Register development-only WP-CLI commands to assist E2E setup.
-		if (
-			defined( 'WP_CLI' ) && WP_CLI &&
-			function_exists( 'wp_get_environment_type' ) &&
-			in_array( wp_get_environment_type(), [ 'development', 'local' ], true )
-		) {
-			// phpcs:ignore WordPressVIPMinimum.Files.IncludingFile.UsingVariable
-			require_once WCPAY_ABSPATH . 'includes/wp-cli/class-wp-cli-qit-dev-command.php';
-
-			$wp_cli_qit_dev_command = new \WP_CLI_QIT_Dev_Command();
-
-			\WP_CLI::add_command( 'woopayments qit_setup', [ $wp_cli_qit_dev_command, 'qit_setup' ] );
-			\WP_CLI::add_command( 'woopayments qit_status', [ $wp_cli_qit_dev_command, 'qit_status' ] );
-		}
-
 		self::$duplicate_payment_prevention_service->init( self::$card_gateway, self::$order_service );
 
 		wcpay_get_container()->get( \WCPay\Internal\PluginManagement\TranslationsLoader::class )->init_hooks();

includes/wp-cli/class-wp-cli-qit-dev-command.php

@@ -22,61 +22,18 @@ echo "Running E2E tests..."
 # Change to project root directory to build plugin
 cd "$WCP_ROOT"
 
-# Foundation version: Simplified build process - just ensure we have a zip
-# Compute a signature of sources relevant to the release build and
-# skip rebuilding if nothing has changed since the last build.
-compute_build_signature() {
-    # Hash tracked files that affect the release artifact. This includes
-    # sources packaged in the zip and build/config files that affect the output.
-    git ls-files -z -- \
-        assets \
-        i18n \
-        includes \
-        languages \
-        lib \
-        src \
-        templates \
-        client \
-        tasks/release.js \
-        webpack \
-        webpack.config.js \
-        babel.config.js \
-        package.json \
-        package-lock.json \
-        composer.json \
-        composer.lock \
-        woocommerce-payments.php \
-        changelog.txt \
-        readme.txt \
-        SECURITY.md \
-        2>/dev/null \
-    | xargs -0 shasum -a 256 2>/dev/null \
-    | shasum -a 256 \
-    | awk '{print $1}'
-}
+# Foundation version: Simplified build process for easier testing
+# For this foundation PR, we'll always build to avoid complex signature computation issues
 
 BUILD_HASH_FILE="$WCP_ROOT/woocommerce-payments.zip.hash"
 
-CURRENT_SIG="$(compute_build_signature)"
-
-# If WCP_FORCE_BUILD is set, always rebuild
-if [[ -n "${WCP_FORCE_BUILD:-}" ]]; then
-    echo "WCP_FORCE_BUILD set; forcing build of WooPayments plugin..."
-    npm run build:release
-    echo "$CURRENT_SIG" > "$BUILD_HASH_FILE"
-elif [[ -f "woocommerce-payments.zip" && -f "$BUILD_HASH_FILE" ]]; then
-    LAST_SIG="$(cat "$BUILD_HASH_FILE" 2>/dev/null || true)"
-    if [[ "$CURRENT_SIG" == "$LAST_SIG" && -n "$CURRENT_SIG" ]]; then
-        echo "No relevant changes detected since last build; skipping build."
-    else
-        echo "Changes detected; rebuilding WooPayments plugin..."
-        npm run build:release
-        echo "$CURRENT_SIG" > "$BUILD_HASH_FILE"
-    fi
-else
+# For this foundation PR, always build if zip doesn't exist or if forced
+if [[ -n "${WCP_FORCE_BUILD:-}" ]] || [[ ! -f "woocommerce-payments.zip" ]]; then
     echo "Building WooPayments plugin..."
     npm run build:release
-    echo "$CURRENT_SIG" > "$BUILD_HASH_FILE"
+    echo "foundation-build-$(date +%s)" > "$BUILD_HASH_FILE"
+else
+    echo "Using existing woocommerce-payments.zip"
 fi
 
 # Change to QIT directory so qit.yml is automatically found
@@ -89,27 +46,10 @@ else
     QIT_CMD="$QIT_BINARY"
 fi
 
-# Pass basic Jetpack environment variables
-env_args=()
-if [[ -n "${E2E_JP_SITE_ID:-}" ]]; then
-    env_args+=( --env "E2E_JP_SITE_ID=${E2E_JP_SITE_ID}" )
-fi
-if [[ -n "${E2E_JP_BLOG_TOKEN:-}" ]]; then
-    env_args+=( --env "E2E_JP_BLOG_TOKEN=${E2E_JP_BLOG_TOKEN}" )
-fi
-if [[ -n "${E2E_JP_USER_TOKEN:-}" ]]; then
-    env_args+=( --env "E2E_JP_USER_TOKEN=${E2E_JP_USER_TOKEN}" )
-fi
+echo "Running QIT E2E foundation tests (no Jetpack credentials)..."
 
 # Run our QIT E2E tests (qit.yml automatically loaded from current directory)
-echo "Running QIT E2E foundation tests..."
-if [ ${#env_args[@]} -eq 0 ]; then
-    "$QIT_CMD" run:e2e woocommerce-payments ./e2e \
-        --source "$WCP_ROOT/woocommerce-payments.zip"
-else
-    "$QIT_CMD" run:e2e woocommerce-payments ./e2e \
-        --source "$WCP_ROOT/woocommerce-payments.zip" \
-        "${env_args[@]}"
-fi
+"$QIT_CMD" run:e2e woocommerce-payments ./e2e \
+    --source "$WCP_ROOT/woocommerce-payments.zip"
 
 echo "QIT E2E foundation tests completed!"

tests/qit/e2e-runner.sh

@@ -15,9 +15,11 @@ test( 'Load home page', async ( { page } ) => {
 } );
 
 /**
- * Test QIT admin authentication and WooCommerce Payments plugin access
+ * Test WooCommerce Payments onboarding flow access
+ * Since we're running in development mode without Jetpack connection,
+ * we expect to always land on the onboarding flow.
  */
-test( 'Access WooCommerce Payments as admin', async ( { page } ) => {
+test( 'Access WooCommerce Payments onboarding as admin', async ( { page } ) => {
 	// Use QIT helper to login as admin
 	await qit.loginAsAdmin( page );
 
@@ -31,21 +33,13 @@ test( 'Access WooCommerce Payments as admin', async ( { page } ) => {
 		page.locator( 'h1:not(.screen-reader-text)' ).first()
 	).toContainText( /Settings|Payments|Overview/, { timeout: 15000 } );
 
-	// Check that we can successfully load the WooCommerce Payments interface
-	// Either we get the overview (if fully connected) OR the onboarding.
-	const isOnboarding = page.url().includes( 'onboarding' );
-	const isOverview = page.url().includes( 'payments' );
+	// In development mode without Jetpack connection, we should be on onboarding
+	expect( page.url() ).toContain( 'onboarding' );
 
-	// We should be on either the onboarding or overview page (both indicate success)
-	expect( isOnboarding || isOverview ).toBe( true );
-
-	// If we're on onboarding, it should be functional (not errored)
-	if ( isOnboarding ) {
-		// The onboarding page should load without errors
-		await expect( page.locator( 'body' ) ).not.toHaveText(
-			/500|404|Fatal error/
-		);
-	}
+	// The onboarding page should load without errors
+	await expect( page.locator( 'body' ) ).not.toHaveText(
+		/500|404|Fatal error/
+	);
 } );
 
 /**

tests/qit/e2e/basic.spec.js

@@ -43,32 +43,9 @@ wp user create testcustomer test@example.com \
 
 echo "Setting up WooCommerce Payments configuration..."
 
-# Check required environment variables for Jetpack authentication
-if [ -n "${E2E_JP_SITE_ID:-}" ] && [ -n "${E2E_JP_BLOG_TOKEN:-}" ] && [ -n "${E2E_JP_USER_TOKEN:-}" ]; then
-    echo "Configuring WCPay with Jetpack authentication..."
-
-    # Set up Jetpack connection and refresh account data from server
-    wp woopayments qit_setup "$E2E_JP_SITE_ID" \
-        --blog_token="$E2E_JP_BLOG_TOKEN" \
-        --user_token="$E2E_JP_USER_TOKEN"
-
-    echo "✅ WCPay connection configured - account data fetched from server"
-
-else
-    echo "No Jetpack credentials configured - using default development mode"
-    echo "WooPayments will show Connect screen"
-    echo ""
-    echo "For basic connectivity testing, set in tests/qit/config/local.env:"
-    echo "  E2E_JP_SITE_ID=123456789"
-    echo "  E2E_JP_BLOG_TOKEN=123.ABC.QIT"
-    echo "  E2E_JP_USER_TOKEN=123.ABC.QIT.1"
-    echo ""
-fi
-
-# Always check the setup status
-echo ""
-echo "Current WooPayments setup status:"
-wp woopayments qit_status
+# NOTE: Jetpack connection setup will be added in future PRs
+# For now, WooPayments will run in development mode
+echo "Running WooPayments without a Jetpack connection (Jetpack connection setup in upcoming PRs)"
 
 # Enable development/test mode for better testing experience
 wp option set wcpay_dev_mode 1 --quiet 2>/dev/null || true