Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple Blocks: Typography appearance settings is overridden by Styles Typography Links settings #64596

Closed
devNigel opened this issue Jun 14, 2022 · 15 comments
Labels
Cross Repo Tracker For issues that are tracking issues in other repositories Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Feature] Full Site Editor The site editor. [Feature] Global Styles The Global Styles tools in the site editor and theme style variations. [Feature Group] Editor Experience Features related to Gutenberg integration on WordPress.com. [Pri] Normal [Product] WordPress.com All features accessible on and related to WordPress.com. [Status] Core Fix Needed A fix within the Core WordPress or Gutenberg project is required to resolve this issue. Triaged To be used when issues have been triaged. [Type] Bug User Report This issue was created following a WordPress customer report

Comments

@devNigel
Copy link

Quick summary

The Styles Typography setting is overriding the Typography settings in Site Title Block.

The Block level settings should have higher priority.

Steps to reproduce

  1. On a simple or AT site with FSE theme, go to Appearance > Editor.
  2. On the Site Title block settings > Typography > Appearance, set it to something like Bold. You can see it works.
  3. Next, go to Styles tab > Typography > Links > Appearance and change it to anything other than Default such as Thin.
  4. You will notice that it affected the Site Title Block display.
  5. The only way to preserve Site Title Block settings is to use Default in Styles tab > Typography > Links > Appearance.

image

image

What you expected to happen

The block level settings should have priority over global settings such as the ones in Stlyes.

What actually happened

Appearance settings in Styles > Typography > Links also affected Site Title block display.

Context

User report: 5295002-zd-woothemes

Simple, Atomic or both?

Simple, Atomic

Theme-specific issue?

No.

Browser, operating system and other notes

No response

Reproducibility

No response

Severity

All

Available workarounds?

Yes, easy to implement

Workaround details

The only way to preserve Site Title Block display settings is to use Default in Styles tab > Typography > Links > Appearance.

@devNigel devNigel added [Type] Bug [Pri] High User Report This issue was created following a WordPress customer report labels Jun 14, 2022
@Joshgrygiel
Copy link

Joshgrygiel commented Jun 14, 2022

📌 HOUSEKEEPING

  • Labels ✅
  • Priority ✅
  • Replicable on Core - Yes

📌 SCRUBBING

  • Tested on Simple ✅
  • Tested on AT ✅
  • Tested on Self-hosted ✅

📌 FINDINGS

  • Confirmed the steps outlined result in the styles tab settings overwriting the appearance settings of the Title Block through the FSE editor

📌 ACTIONS

  • Marked as Triaged for Quality Squad review
  • Transferred to WordPress/Gutenberg external repo: here

📌 Message to Author - @devNigel I can confirm the individual Title Block typography styles are overwritten by the Styles tab settings. I opened this issue on Wordpress / Gutenberg as the issue is appearing on self-hosted

@Joshgrygiel Joshgrygiel added the [Feature] Full Site Editor The site editor. label Jun 14, 2022
@Joshgrygiel Joshgrygiel added the Triaged To be used when issues have been triaged. label Jun 14, 2022
@cometgrrl cometgrrl added [Status] Core Fix Needed A fix within the Core WordPress or Gutenberg project is required to resolve this issue. Cross Repo Tracker For issues that are tracking issues in other repositories labels Jul 6, 2022
@rw-ye
Copy link

rw-ye commented Aug 2, 2022

Another report here: 5443273-zd-woothemes

The font size in Styles is also overriding the size set in block settings.

@github-actions
Copy link

github-actions bot commented Aug 2, 2022

Support References

This comment is automatically generated. Please do not edit it.

  • 5295002-zen
  • 5443273-zen
  • 5765619-zen
  • 5932564-zen
  • 6300599-zen
  • 6330054-zen
  • 6370750-zen

@Robertght
Copy link

Another case with Byrne in 5765619-zen

@cuemarie cuemarie changed the title Site Title Block: Typography appearance settings is overridden by Styles Typography Links settings Multiple Blocks: Typography appearance settings is overridden by Styles Typography Links settings Mar 21, 2023
@cuemarie
Copy link

User reports from #73012 :

  • 5932564-zd-woothemes

@cuemarie
Copy link

cuemarie commented Mar 28, 2023

I think this may be related: WordPress/gutenberg#44931 Global Styles: Styles specificity and users expectations

If so, the TLDR here is that GB is working as intended, but has a confusing UX due to the hierarchy of elements vs blocks.

@dsas Do you agree this is part of that larger conversation?

@dsas
Copy link
Contributor

dsas commented Mar 28, 2023

It's part of that conversation. Maybe this could be addressed differently, (similarly to navigation) but maybe that just causes a different set of UX problems.

In either case it's definitely a problem that needs thinking about and addressing in Core Gutenberg and I see a GB bug has been created

@the-misha
Copy link

Another user report: 42096785-hc

@tvolpert
Copy link

tvolpert commented Apr 5, 2023

another one here:

  • 36766118-hc

@jartes
Copy link
Contributor

jartes commented May 19, 2023

Another report when using the Site Title block and trying to change the styles:

6300599-zd-woothemes

@khristiansnyder
Copy link

Ran into this issue today as well in #6330054-zd. Had to remove the link styling so the font size of the site title block could be used properly.

@cuemarie
Copy link

cuemarie commented Jun 5, 2023

Encountered this again here: #6370750-zen

User was super frustrated and confused as to why their Site Title block's changes wouldn't update - and indeed the UI is hard to understand here. I walked them through resetting Styles > Typography > Link > Font Size so that they can control the Site Title block from the block settings again.

@cuemarie
Copy link

cuemarie commented Oct 5, 2023

It's been identified above that this issue is primarily an issue of confusing UI, which is being discussed in core here: WordPress/gutenberg#44931

📌 ACTIONS

  • With that in mind, I've downgraded the priority from High to Normal to better reflect its status in the larger context of open bugs in this repo.

@github-actions github-actions bot added the Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". label Oct 5, 2023
@cuemarie cuemarie added [Pri] Normal [Feature] Global Styles The Global Styles tools in the site editor and theme style variations. [Product] WordPress.com All features accessible on and related to WordPress.com. [Feature Group] Editor Experience Features related to Gutenberg integration on WordPress.com. and removed [Pri] High Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". labels Oct 5, 2023
@annezazu
Copy link

annezazu commented Sep 3, 2024

Noting that there's a PR underway to address this: WordPress/gutenberg#64911 and that I can still replicate the original report. I've added the PR as needs review to the connecting the dots board for now.

@github-actions github-actions bot added the Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". label Sep 3, 2024
@davemart-in
Copy link
Contributor

Closing this out as it seems to be fixed by WordPress/gutenberg#64911

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cross Repo Tracker For issues that are tracking issues in other repositories Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Feature] Full Site Editor The site editor. [Feature] Global Styles The Global Styles tools in the site editor and theme style variations. [Feature Group] Editor Experience Features related to Gutenberg integration on WordPress.com. [Pri] Normal [Product] WordPress.com All features accessible on and related to WordPress.com. [Status] Core Fix Needed A fix within the Core WordPress or Gutenberg project is required to resolve this issue. Triaged To be used when issues have been triaged. [Type] Bug User Report This issue was created following a WordPress customer report
Development

No branches or pull requests