-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Figure elements (embeds, videos, and images) not 100% wide after Gutenberg 13.5 update #64964
Comments
Reports:
|
5321864-zd-woothemes 35899784-hc |
Another report via hc-30341981 |
📌 SCRUBBING
📌 FINDINGS/SCREENSHOTS/VIDEO
📌 ACTIONS
|
Bringing over from #64927 5321874-zd-woothemes |
@griffbrad is this something the Calypso team could look into? |
We can at least try to better understand the source of the bug to get it sorted out. @chad1008, would you be willing to look and see what might have changed with these styles since Gutenberg 13.5? |
Sorry @griffbrad, I missed this ping until now somehow. Yes, I'm happy to take a look! |
It looks like this may already have been fixed in 13.6.0, which is currently live on Simple sites. The lack of new reports since 13.6.0 hit Simple a week ago is also encouraging. @Greatdane @aleone89 @rakshitwesley @eduardozulian can any of y'all confirm that affected users are no longer seeing this issue? |
@chad1008, sorry for the delay here. I haven't contacted any users, but this is still happening with at least two sites:
Both customers have some custom CSS. Once removed, the problem reappears. Pinging @Greatdane @aleone89 @rakshitwesley again in case you all missed the initial ping as I did! |
Support References This comment is automatically generated. Please do not edit it.
|
Thanks @eduardozulian. Odd that these sites are still having trouble. Specifically on the site from 5321874-zen, I can see the issue on the site itself, but I cannot reproduce it on my own sites. I've even tried replicating the exact same content. There are some subtle differences in the markup that I'm not sure of the source of. Specifically, the site in question isn't getting a style that my sites are generating:
That apparently should be in the Because I can't replicate it outside of the customer's site, I don't have a good way to track down what caused it and when. We may need to keep relying on the custom CSS for this one until it becomes more traceable. |
Another case of this issue here: 6408573-zd-woothemes |
This seems edge case and there have been no reports or updates for over a year. Closing it out, but happy to open this back up if it's still an issue. |
Quick summary
Some reports show that elements under the
figure
HTML tab are smaller than they are in the editor. Examples include:The code responsible for it is coming from user agent stylesheet:
This happens when Gutenberg 13.5 is active. When disabled, the elements appear in the same size they are in the editor.
Important: This might be theme-dependant as some do force specific margins for
figure
.Steps to reproduce
What you expected to happen
See images as I see in the editor, taking 100% of its container
What actually happened
Context
User report.
Internal discussion p1656146114576809-slack-C03TY6J1A
Simple, Atomic or both?
Simple, Atomic
Theme-specific issue?
Yes, but some of them at least.
On Blockbase, the issue happens on images inside columns:
On Lovecraft, this also applies to YouTube embeds
Browser, operating system and other notes
No response
Reproducibility
Consistent
Severity
Some (< 50%)
Available workarounds?
Yes, easy to implement
Workaround details
Two possible workarounds:
The text was updated successfully, but these errors were encountered: