Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plans 2023: Plan grid styling is not wrapping correctly #74749

Closed
jjchrisdiehl opened this issue Mar 22, 2023 · 2 comments
Closed

Plans 2023: Plan grid styling is not wrapping correctly #74749

jjchrisdiehl opened this issue Mar 22, 2023 · 2 comments
Labels
[Feature Group] A8C Marketing & Sales Automattic's marketing and sales operations for WordPress.com. [Feature] Pricing Feedback related to the pricing structure of WordPress.com's plans and services. [Platform] Atomic [Platform] Simple [Pri] Low [Product] WordPress.com All features accessible on and related to WordPress.com. [Type] Bug User Report This issue was created following a WordPress customer report

Comments

@jjchrisdiehl
Copy link
Contributor

Quick summary

The plan comparison table on /plans/[your-site-url] under Compare Plans has some styling issues where the text breaks outside of its bounding box for the left hand column headers.

image

I'm not entirely sure why this is the case, but it looks like the table is using an svg for the borders which may be why the width of the header is wider than the apparent column.

Steps to reproduce

  • Go to /plans/[your-site-url]
  • Click on Compare Plans at the bottom of the page
  • Modify the header text in the left hand column to be longer, eventually it will overlap the column's right hand border

What you expected to happen

I expected the text to simply wrap to the next line once the sentence was longer than the column width.

What actually happened

The text continues beyond the column's border onto the next column.

Impact

All

Available workarounds?

No but the platform is still usable

Platform (Simple and/or Atomic)

Simple, Atomic

Logs or notes

I found this originally while looking at the interface in Spanish. While the columns look fine in English, once we translate these strings into other languages we may run into this issue since the amount of text needed in another language may exceed that of English.

@jjchrisdiehl jjchrisdiehl added [Type] Bug User Report This issue was created following a WordPress customer report Needs triage Ticket needs to be triaged labels Mar 22, 2023
@github-actions github-actions bot added [Platform] Atomic [Platform] Simple [Pri] High [Status] Priority Review Triggered Quality squad has been notified of this issue in #dotcom-triage-alerts labels Mar 22, 2023
@karenroldan
Copy link
Contributor

📌 ACTIONS

  • Due to the age of this issue, I've downgraded the priority from High to Low to better reflect its status in the larger context of open bugs in this repo.

@karenroldan karenroldan added [Pri] Low [Feature Group] A8C Marketing & Sales Automattic's marketing and sales operations for WordPress.com. [Feature] Pricing Feedback related to the pricing structure of WordPress.com's plans and services. [Product] WordPress.com All features accessible on and related to WordPress.com. and removed [Pri] High [Status] Priority Review Triggered Quality squad has been notified of this issue in #dotcom-triage-alerts Needs triage Ticket needs to be triaged labels Oct 10, 2023
@davemart-in
Copy link
Contributor

I just checked. It looks like the text now wraps. Closing this out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature Group] A8C Marketing & Sales Automattic's marketing and sales operations for WordPress.com. [Feature] Pricing Feedback related to the pricing structure of WordPress.com's plans and services. [Platform] Atomic [Platform] Simple [Pri] Low [Product] WordPress.com All features accessible on and related to WordPress.com. [Type] Bug User Report This issue was created following a WordPress customer report
Development

No branches or pull requests

3 participants