Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jetpack Backups don't run when an Atomic site's storage is full #81490

Closed
joweber123 opened this issue Sep 7, 2023 · 4 comments
Closed

Jetpack Backups don't run when an Atomic site's storage is full #81490

joweber123 opened this issue Sep 7, 2023 · 4 comments
Labels
[Feature] Backups The Jetpack Backup product [Feature Group] Other Infrastructure Miscellaneous infrastructure features and improvements on WordPress.com. [Feature] Other Atomic Infrastructure Anything else related to Atomic. [Platform] Atomic [Pri] Low [Product] WordPress.com All features accessible on and related to WordPress.com. Triaged To be used when issues have been triaged. [Type] Bug

Comments

@joweber123
Copy link

Quick summary

When an Atomic site has maxed out its storage, backups do not run. Apparently, when Jetpack tries to upload the helper script (the thing that fetches data from the site), it is unable to because there is no more space for it, thus the backup cannot run.

Could we perhaps adjust the storage to leave enough storage to upload the helper script?

Related Slack Conversation - p1693970297136969-slack-C03TY6J1A
Related Documentation Update Request - 84-gh-Automattic/reactor

Steps to reproduce

  1. Max out the storage on an Atomic Site
  2. Look at the rewind debugger to see error messages and issues with "Full Backup Attempts"

What you expected to happen

I would expect that our backups would still run even with storage maxed out.

What actually happened

Storage gets maxed out and there is no error message on the user's end indicating that backups are not happening because of a storage issue.

Impact

Some (< 50%)

Available workarounds?

Yes, easy to implement

Platform (Simple and/or Atomic)

Atomic

Logs or notes

No response

@joweber123 joweber123 added [Type] Bug Needs triage Ticket needs to be triaged [Product] WordPress.com All features accessible on and related to WordPress.com. [Feature Group] Other Infrastructure Miscellaneous infrastructure features and improvements on WordPress.com. [Feature] Other Atomic Infrastructure Anything else related to Atomic. labels Sep 7, 2023
@cuemarie
Copy link

cuemarie commented Sep 7, 2023

📌 REPRODUCTION RESULTS

  • Did not reproduce - this looks to be pretty consistent across user experiences
  • Not sure if this is a bug or working by design; I recall there are a few issues that arise when sites max out their storage. If this behavior is expected, then we can adapt this report to an Enhancement request for this suggestion:

Could we perhaps adjust the storage to leave enough storage to upload the helper script?

📌 ACTIONS

  • @jeherve pinging you in case there's any insight / help Jetpack can offer here.

@cuemarie cuemarie added Triaged To be used when issues have been triaged. and removed Needs triage Ticket needs to be triaged labels Sep 7, 2023
@jeherve jeherve added the [Feature] Backups The Jetpack Backup product label Sep 8, 2023
@jeherve
Copy link
Member

jeherve commented Sep 8, 2023

cc'ing @Automattic/yamato-backup who may know more.

@pypt
Copy link

pypt commented Sep 8, 2023

It is indeed accurate that we upload a PHP helper script, and later we talk to it over HTTP/SSH to get the backup/restore going.

Let us at @Automattic/yamato-backup know if you have any questions.

@davemart-in
Copy link
Contributor

Closing this out as expected behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Backups The Jetpack Backup product [Feature Group] Other Infrastructure Miscellaneous infrastructure features and improvements on WordPress.com. [Feature] Other Atomic Infrastructure Anything else related to Atomic. [Platform] Atomic [Pri] Low [Product] WordPress.com All features accessible on and related to WordPress.com. Triaged To be used when issues have been triaged. [Type] Bug
Development

No branches or pull requests

5 participants