Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intermittent: Customizer CSS is missing after site goes Atomic #81593

Closed
metabreakr opened this issue Sep 11, 2023 · 9 comments
Closed

Intermittent: Customizer CSS is missing after site goes Atomic #81593

metabreakr opened this issue Sep 11, 2023 · 9 comments
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Feature] Customizer The site customizer for traditional, non-block themes. [Feature Group] Appearance & Themes Features related to the appearance of sites. [Platform] Atomic [Pri] Low [Product] WordPress.com All features accessible on and related to WordPress.com. Triaged To be used when issues have been triaged. [Type] Bug

Comments

@metabreakr
Copy link

Quick summary

Similar to #76642 — when a simple site is built and CSS is added through the Customizer, that CSS is lost when a site goes Atomic — the Customizer's Additional CSS field is blank, similar to when one theme is switched for another.

Steps to reproduce

  1. Activate a Varia theme (e.g. Shawburn) on a simple site
  2. Add some custom CSS to the Customizer
  3. Push the site to Atomic
  4. Open the Customizer again, and observe that the CSS is missing

What you expected to happen

I expected the CSS to remain in the Customizer after the site goes Atomic.

What actually happened

Any CSS added in the Customizer is removed, and needs to be added again.

Impact

Most (> 50%)

Available workarounds?

Yes, easy to implement

Platform (Simple and/or Atomic)

Atomic

Logs or notes

This most recently occurred when building pdEkSe-4WM-p2

@metabreakr metabreakr added [Type] Bug [Feature Group] Appearance & Themes Features related to the appearance of sites. [Feature] Customizer The site customizer for traditional, non-block themes. Needs triage Ticket needs to be triaged [Product] WordPress.com All features accessible on and related to WordPress.com. labels Sep 11, 2023
@cuemarie
Copy link

📌 REPRODUCTION RESULTS

  • Tested on TT3 – Could Not Replicate
  • Tested on Varia – Could Not Replicate

📌 FINDINGS/SCREENSHOTS/VIDEO

I was not able to reproduce this issue on Varia or TT3 🤔

Varia:

uy2WFJ.mp4

TT3:

iSPNAw.mp4

Will try again with some child themes and report back...

@metabreakr
Copy link
Author

@cuemarie Hmm. I will try and replicate this again in the same way that I built the site in the P2 (not that it's anything out of the ordinary)

@metabreakr
Copy link
Author

I couldn't reproduce this again, so will close this issue for now until it happens again.

@ccwalburn
Copy link

Reopening this issue as this has happened again.
7093294-zd-a8c
User was using the Morden theme on a Premium plan and did not change themes after upgrading and going AT.

@ccwalburn ccwalburn reopened this Sep 27, 2023
@github-actions
Copy link

Support References

This comment is automatically generated. Please do not edit it.

  • 7093294-zen

@github-actions github-actions bot added the Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". label Sep 27, 2023
@cuemarie
Copy link

THanks @ccwalburn - I just ran a site using Morden through 2 tests and still wasn't able to repro:

  • Test 1: Simple Business Site -> Atomic Business site (transferred to AT via plugin install) Recording
  • Test 2: Simple Premium Site -> Atomic Business site (upgraded and transferred to AT via plugin install) Recording

📌 ACTIONS

  • I'll leave this open to see if anyone else runs into it.

📌 Message to Future HEs

  • Transferring AT alone does not seem to explain this behavior - if you run into users who report this, try to get as much information as you can about the steps they took to upgrade, when the CSS was originally added to their site, etc, so that we can try to identify any patterns. Thank you!

@cuemarie cuemarie added [Pri] Low Triaged To be used when issues have been triaged. and removed [Pri] Normal Needs triage Ticket needs to be triaged labels Sep 28, 2023
@cuemarie cuemarie changed the title Customizer CSS is missing after site goes Atomic Intermittent: Customizer CSS is missing after site goes Atomic Sep 28, 2023
@metabreakr
Copy link
Author

@cuemarie Could this be related to #82363 ?

@cuemarie
Copy link

cuemarie commented Oct 4, 2023

Could this be related to #82363 ?

It certainly seems like a similar issue - intermittently losing theme customizations (whether that's via CSS, global styles, or templates) when sites go AT. It's tough to find a pattern tho as we haven't been able to reproduce either one consistently, though, so for now we'll need to keep both open and see if we can find a pattern if/when more reports come in.

@davemart-in
Copy link
Contributor

Looks like this may be resolved? Closing this out since it's not seen any momentum in over a year.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Feature] Customizer The site customizer for traditional, non-block themes. [Feature Group] Appearance & Themes Features related to the appearance of sites. [Platform] Atomic [Pri] Low [Product] WordPress.com All features accessible on and related to WordPress.com. Triaged To be used when issues have been triaged. [Type] Bug
Development

No branches or pull requests

4 participants