-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to Swap Templates for Pages and Posts that contain an Amazon Embed #86207
Comments
This user is experiencing the issue: 7544640-zd-a8c |
Support References This comment is automatically generated. Please do not edit it.
|
📌 REPRODUCTION RESULTS
📌 FINDINGS/SCREENSHOTS/VIDEO Test on simple: CleanShot.2024-01-10.at.15.50.08.mp4📌 ACTIONS
📌 Message to Author |
@liviopv I did some further testing and can still consistently reproduce the issue on both the Byrne and Twenty-Twenty Two themes. Twenty-Twenty Two - Simple Site Screen.Recording.2024-01-11.at.3.17.44.pm.movByrne - Simple Site Screen.Recording.2024-01-11.at.3.26.34.pm.movTwenty-Twenty Two - AT Site Screen.Recording.2024-01-11.at.3.32.43.pm.movWhen trying to select the template, nothing happens and the browser essentially freezes. I was also able to reproduce on my second WPCOM account. |
@rw-ye @mgozdis in both cases, the Amazon Kindle link being used seems incorrect. Documentation for the block https://wordpress.org/documentation/article/amazon-kindle-embed/ indicates the block will only accept URLs formatted in a very specific way:
That said, even though I cannot reproduce the swap template issues when using correct links, I do see the multiple network requests @mgozdis flagged above, so I opened WordPress/gutenberg#58267 in core. Keep in mind that this is most likely not going to be a quick fix, and there were discussions in the past advocating to remove this block, so it's a good idea to recommend alternative embeds to the customers. |
@nuriapenya to ping Dotorg Design to offer help with a UI fix. |
📌 REPRODUCTION RESULTS
📌 ACTIONS
@inaikem do we want to keep this and have someone improve the above or open a new one? |
Quick summary
There is currently an issue where trying to swap a template on a page/post that contains an Amazon embed will cause the page to freeze and show an error message:
This editor has encountered an unexpected error
.So far, I have been able to reproduce the issue on two FSE themes:
Steps to reproduce
This editor has encountered an unexpected error
.Screen.Recording.2024-01-10.at.12.53.35.pm.mov
What you expected to happen
To select a different template on the page/post
What actually happened
When trying to change the template, the entire page/post freezes, and a template can not be selected.
Impact
Some (< 50%)
Available workarounds?
Yes, easy to implement
Platform (Simple and/or Atomic)
Atomic and Simple
Logs or notes
As a workaround, deleting the embed block, switching the template and then re-adding the embed block will work.
The text was updated successfully, but these errors were encountered: