Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkbox toggle color being overridden #86946

Closed
lsl opened this issue Jan 23, 2024 · 2 comments · Fixed by #95599
Closed

Checkbox toggle color being overridden #86946

lsl opened this issue Jan 23, 2024 · 2 comments · Fixed by #95599
Labels
[Feature Group] Site Settings & Tools Settings and tools for managing and configuring your site. [Feature] Site Settings All other general site settings. [Pri] Low [Type] Bug

Comments

@lsl
Copy link
Contributor

lsl commented Jan 23, 2024

Quick summary

The Checkbox toggle color is being overridden somewhere and leaked into the wider application. This has been reported a few times but I was finally able to narrow down a reproduction:

Steps to reproduce

  1. Starting at URL: https://wordpress.com/settings/discussion/jetstatstest.wpcomstaging.com with the default / modern color scheme.
  2. Note the color of the checkbox toggles
  3. Click Install ActivityPub button (it just takes you to the marketplace)
  4. Return to any settings page
  5. You'll now see green check toggles instead of blue

Browser

Mozilla Firefox

Other notes

Expected:
Screenshot 2024-01-23 at 16-46-38 Discussion Settings ‹ Creator Atomic Test Site — WordPress com

Got:
Screenshot 2024-01-23 at 16-46-43 Discussion Settings ‹ Creator Atomic Test Site 2 — WordPress com

@lsl lsl added the [Type] Bug label Jan 23, 2024
@jeherve jeherve transferred this issue from Automattic/bugomattic Jan 29, 2024
@jeherve jeherve added [Feature] Site Settings All other general site settings. [Feature Group] Site Settings & Tools Settings and tools for managing and configuring your site. labels Jan 29, 2024
@inaikem inaikem closed this as completed Oct 13, 2024
@inaikem inaikem reopened this Oct 13, 2024
@lsl lsl added [Pri] Low and removed [Pri] Low labels Oct 14, 2024
@mmtr
Copy link
Member

mmtr commented Oct 22, 2024

I can still reproduce this, but this step is now different:

  1. Click Install ActivityPub button (it just takes you to the marketplace)

I had to click on "Fediverse settings now live in Marketing Connections" and then on "Install ActivityPub".

Screen.Recording.2024-10-22.at.17.46.04.mov

@Automattic/lego since you have recently worked on color schemes, maybe you can take a look?

Alternatively, since the issue is reproducible only when going through the marketing connections (a social tool) to install the ActivityPub plugin, maybe @Automattic/loop can lend a hand here too?

@lsl
Copy link
Contributor Author

lsl commented Oct 22, 2024

It's the marketplace plugin listing css leaking, e.g. visit https://wordpress.com/plugins/elementor/test1231374.wpcomstaging.com, then navigate to a settings page.

The plugin doesn't need to be installed to create the issue but installing the plugin shows where the green is coming from:

Image

The green css override for the enable autoupdates toggle is leaking into the global scope somewhere. I'd just remove the green override and let the screen use the users color scheme like it should be.

Edit: fixing here #95599

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature Group] Site Settings & Tools Settings and tools for managing and configuring your site. [Feature] Site Settings All other general site settings. [Pri] Low [Type] Bug
Projects
Development

Successfully merging a pull request may close this issue.

5 participants