Sites: unresponsive link until screenshot loads

[simison]

All sites links are unresponsive while screenshots are loading.

Screen.Recording.2024-03-25.at.13.13.11.mov

Steps to reproduce

Use slow connection; sandboxed with lots of sites is usually slow enough.

1. Starting at URL: /sites
2. Screenshots keep loading / pulsating
3. Try click the site name before screenshot; nothing happens until screenshot(s) finish loading
4. Go back and try "settings" link under three dots; it works right away

What I expected

What happened instead

Browser / OS version

Screenshot / Video

Context / Source

[sejas]

@simison, I took a quick look and found that the slow loading is related to the /home/$siteSlug page and not the way we navigate from /sites.

Here are the steps to reproduce:

1. Sandbox the API to add some delay in the responses.
2. Navigate to /settings/general/$siteSlug
3. Quickly click on Home in the left sidebar to navigate to the home dashboard.
4. Observe the URL changes quickly in the browser, but it takes several seconds to load the Home page.

navigate-from-settings-to-home.mp4

Before realising the problem is in the Home, I tried using navigate function and also navigating to Home from the ellipsis menu with same results.

[maciejpilarski]

📌 ACTIONS
– triaged

[lsl]

The fullscreen launchpad redirect check seems to block a few things,

wp-calypso/client/my-sites/customer-home/controller.jsx

Lines 63 to 80 in 955b956

	try {
	const {
	launchpad_screen: launchpadScreenOption,
	site_intent: siteIntentOption,
	checklist: launchpadChecklist,
	} = await fetchLaunchpad( slug );
	if (
	launchpadScreenOption === 'full' &&
	! areLaunchpadTasksCompleted( launchpadChecklist, isSiteLaunched )
	) {
	// The new stepper launchpad onboarding flow isn't registered within the "page"
	// client-side router, so page.redirect won't work. We need to use the
	// traditional window.location Web API.
	redirectToLaunchpad( slug, siteIntentOption, verified );
	return;
	}
	} catch ( error ) {}

Commenting it out things look a bit better:

Note the highlighted requests in both screenshots are for the in page launchpad tasks shown on My Home.

We could probably add a skip launchpad param to the sites already launched but I'm hesitant to do so when removal of this should be happening near-term, pfuQfP-J5-p2 fyi @bogiii

[sejas]

Closing this issue because we don't display site screenshots anymore.