Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logged-in Performance Profiler: Add loading state #94543

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

zaguiini
Copy link
Contributor

@zaguiini zaguiini added Reviewer Can Merge PR author indicates the reviewer is free to merge/deploy if they want to own the change. Logged-in Performance Profiler i1 labels Sep 13, 2024
@zaguiini zaguiini self-assigned this Sep 13, 2024
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Sep 13, 2024
@zaguiini zaguiini force-pushed the performance-profiler/loading-state branch from 7b8ee6e to a6a2bcf Compare September 13, 2024 14:03
@matticbot
Copy link
Contributor

matticbot commented Sep 13, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~568 bytes added 📈 [gzipped])

name                  parsed_size           gzip_size
site-performance          +3220 B  (+0.2%)     +939 B  (+0.2%)
performance-profiler       +895 B  (+0.3%)     +353 B  (+0.4%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Logged-in Performance Profiler: Add loading state
@zaguiini zaguiini force-pushed the performance-profiler/loading-state branch from a6a2bcf to bb8582a Compare September 13, 2024 14:24
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug performance-profiler/loading-state on your sandbox.

Copy link
Contributor

@vykes-mac vykes-mac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@vykes-mac vykes-mac merged commit e982990 into trunk Sep 13, 2024
11 checks passed
@vykes-mac vykes-mac deleted the performance-profiler/loading-state branch September 13, 2024 17:43
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 13, 2024
@a8ci18n
Copy link

a8ci18n commented Sep 13, 2024

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/16717158

Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday.

Thank you @zaguiini for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented Sep 15, 2024

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Logged-in Performance Profiler i1 Reviewer Can Merge PR author indicates the reviewer is free to merge/deploy if they want to own the change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants