Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hosting Features: Activation modal button styling improvements #94923

Closed
taipeicoder opened this issue Sep 26, 2024 · 2 comments
Closed

Hosting Features: Activation modal button styling improvements #94923

taipeicoder opened this issue Sep 26, 2024 · 2 comments
Assignees
Labels
[Feature] Calypso & wp-admin Navigation All navigation in Calypso and wp-admin, and the unified transitions between the two. [Feature Group] Content Management Features related to the tools and screens that admins use to manage their sites core content. [Feature] Hosting Dashboard Needs triage Ticket needs to be triaged [Product] WordPress.com All features accessible on and related to WordPress.com. [Type] Enhancement

Comments

@taipeicoder
Copy link
Contributor

taipeicoder commented Sep 26, 2024

Quick summary

The Activate Hosting Features modal has a couple of buttons that feel out of place with the design system:

"Choose a data center instead" button

Default Hover
Screenshot 2024-09-26 at 1 23 55 PM Screenshot 2024-09-26 at 1 24 22 PM

"Cancel" button (@ianstewart also noted that its position feels off).

Default Hover
Screenshot 2024-09-26 at 1 24 05 PM Screenshot 2024-09-26 at 1 24 16 PM

Steps to reproduce

  1. With a Simple site on a Business plan, visit https://wordpress.com/hosting-features/{SITE}.
  2. Click on the "Activate now" button.

What you expected to happen

The buttons in the modal should follow the design system.

What actually happened

The buttons in the modal don't seem to follow the design system.

Impact

Some (< 50%)

Available workarounds?

No but the platform is still usable

If the above answer is "Yes...", outline the workaround.

No response

Platform (Simple and/or Atomic)

No response

Logs or notes

No response

@taipeicoder taipeicoder added [Type] Enhancement [Status] Needs Design Add this to PRs that need input from Design [Feature] Calypso & wp-admin Navigation All navigation in Calypso and wp-admin, and the unified transitions between the two. Needs triage Ticket needs to be triaged [Product] WordPress.com All features accessible on and related to WordPress.com. [Feature Group] Content Management Features related to the tools and screens that admins use to manage their sites core content. [Feature] Hosting Dashboard labels Sep 26, 2024
@javierarce
Copy link

We've been working on improvements to this modal here, and that UI has changed a bit.

Here's the proposed design: wCm5Tzb7JBaG4WNowWbjES-fi-5085_18

@javierarce javierarce self-assigned this Sep 30, 2024
@jartes
Copy link
Contributor

jartes commented Oct 24, 2024

📌 REPRODUCTION RESULTS

  • Tested on Simple – Could Not Replicate

📌 FINDINGS/SCREENSHOTS/VIDEO

📌 ACTIONS

  • Triaged
  • Closed as fixed / resolved

@jartes jartes closed this as completed Oct 24, 2024
@github-actions github-actions bot removed the [Status] Needs Design Add this to PRs that need input from Design label Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Calypso & wp-admin Navigation All navigation in Calypso and wp-admin, and the unified transitions between the two. [Feature Group] Content Management Features related to the tools and screens that admins use to manage their sites core content. [Feature] Hosting Dashboard Needs triage Ticket needs to be triaged [Product] WordPress.com All features accessible on and related to WordPress.com. [Type] Enhancement
Projects
Development

No branches or pull requests

3 participants