-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stepper: calypso_signup_complete
event not firing in es onboarding flow
#95047
Comments
Related discussion with findings in Slack: p1727704611670019-slack-C073776NJ66 I confirmed this only happens for |
This feels worth looking into, irrespective if being due to what may be an exception (the use of |
I did some digging around to understand this a bit more. I haven't gotten too deep though. The processing step is indeed the main control unit for running any "pending action" (singular, from the looks of it) before recording the signup-complete event. I think that's all good since it works. There is some arbitrariness in how any step or flow (basically anything and from anywhere) can set a "pending action" into the data store, and that immediately becomes a criterion for the signup-complete event once in the processing step. My other concerns are (1) the singular form of this i.e. only the last set "pending action" is resolved by the processing step before recording the event, and (2) nothing clears the "pending action" array once called in the processing step. I sense something's a little shady here, but I cannot yet pinpoint an issue. What may be worth looking into further:
|
Thank you for you analysis @chriskmnds. I can see how the structure of the processing-step may be prone to shadiness and breakage.
|
@escapemanuele you can either create a new issue for this or update this one. Just anything to be logged and be available for grabs :-) |
Steps taken:
calypso_signup_complete
event when I landed at the checkout pagees-stepper-flow-test-gmail.mp4
[Update on 2024-10-03]
I reported this issue on 2024-10-01. However, during my audit yesterday, 2024-10-02, this issue no longer occurred.
calypso_signup_complete
event is firing correctly when@ gmail
address is used.The text was updated successfully, but these errors were encountered: