-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
100-year-plan: Embed Calendly Widget Popup #95291
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~88 bytes removed 📉 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~297 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
) : ( | ||
<FullPageVideoContainer isMobile={ isMobile }> | ||
{ videoElement } | ||
{ !! loadingText && <h1 className="wp-brand-font">{ loadingText }</h1> } | ||
</FullPageVideoContainer> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The HundredYearLoaderView
component has been updated to support rendering video without a container so we can reuse it in different contexts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does client/landing/stepper/declarative-flow/internals/steps-repository/hundred-year-plan-diy-or-difm/schedule-appointment-modal.tsx
still need to exist? Or it'll be handle in next PR?
No need anymore; I'm preparing cleanup PR. |
.../stepper/declarative-flow/internals/steps-repository/hundred-year-plan-diy-or-difm/index.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll deploy this PR as it is and have follow-up PRs for the minor adjustments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean something like this?
Yes, how do you feel about it?
I'll deploy this PR as it is and have follow-up PRs for the minor adjustments.
Sounds good! 🚢
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/16907357 Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday. Thank you @bogiii for including a screenshot in the description! This is really helpful for our translators. |
Translation for this Pull Request has now been finished. |
Proposed Changes
Applied feedback from the previous two PRs that will be closed since this PR is replacement:
Testing Instructions
/setup/hundred-year-plan/diy-or-difm?flags=100year%2Fvip
Pre-merge Checklist