-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add We’ll take it from here!
step when user tries to migrate a wpcom site
#95294
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~63 bytes added 📈 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~815 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~48 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
We’ll take it from here!
step when user tries to migrate a wpcom siteWe’ll take it from here!
step when user tries to migrate a wpcom site
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found two details that might be worth taking a look:
- Clicking on the
Explore features
link takes you to the site that was created during the flow. Shouldn't this direct you to your existing WPCOM site? - There's a style jump in the width of the link cards when coming back from /home.
This behaviours can be seen in this video:
Screen.Recording.2024-10-14.at.14.38.52.mov
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this @gabrielcaires !
Looks good and works well overall!
However, I've noticed the following two issues-
- No spacings in the sides in the mobile view
- Though
className
is added as an optional property, we don't check if it's actually provided before adding classes prefixed by it. Resulting inundefined
classnames in other steps
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
I am unsure; I copied it from another similar button, but I also think they can explore another feature from the new site(!?) Both solutions are acceptable. |
@andres-blanco css.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
Deferring the approval to @andres-blanco
@andres-blanco I am merging bot unblock this PR; if we have any news about the link, we can quickly update this PR. |
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/16921227 Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday. Thank you @gabrielcaires for including a screenshot in the description! This is really helpful for our translators. |
Translation for this Pull Request has now been finished. |
I was thinking we'd take you to the site that was created during the flow. |
Closes #95293
Proposed Changes
migration
andsite-migration
flows, after the user submits the formNote
There is another scenario we should display this screen It will be implemented as part of task #95293 but the content is already available on this PR.
Testing Instructions
/setup/migration
flowYour site is already on WordPress.com
Pre-merge Checklist