Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Full post" being displayed in the new post emails even if the "Excerpt" option is turned on #95309

Open
Robertght opened this issue Oct 11, 2024 · 13 comments
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Feature Group] Content Management Features related to the tools and screens that admins use to manage their sites core content. [Feature] Site Content Emails All emails generated for new site content, like emails going out to subscribers. [Platform] Simple [Pri] High [Product] WordPress.com All features accessible on and related to WordPress.com. [Status] Priority Review Triggered Quality squad has been notified of this issue in #dotcom-triage-alerts Triaged To be used when issues have been triaged. [Type] Bug

Comments

@Robertght
Copy link

Quick summary

Even if we set an excerpt and have it set under Settings > Writing, the full blog post is being display in the email notification.

Steps to reproduce

  1. Go to Settings > Reading and set under "RSS feed settings" to "Excerpt"
  2. Create a new post and add content to it
  3. Set an excerpt and publish it
  4. Check results

What you expected to happen

The excerpt text should be displayed in the email notification.

What actually happened

It displayed the full post in the email notification.

Impact

All

Available workarounds?

Yes, easy to implement

If the above answer is "Yes...", outline the workaround.

Using the More block can help go around this.

Platform (Simple and/or Atomic)

Simple

Logs or notes

So far tested on Simple sites due to lack of time.

Previous ref: Automattic/jetpack#34372 (comment) cc @ivan-ottinger if you're still working on these

Also confirmed here: p1728635005695919-slack-C03TY6J1A by @mxhassani

@Robertght Robertght added [Feature Group] Content Management Features related to the tools and screens that admins use to manage their sites core content. [Feature] Site Content Emails All emails generated for new site content, like emails going out to subscribers. [Product] WordPress.com All features accessible on and related to WordPress.com. [Type] Bug Needs triage Ticket needs to be triaged [Pri] High labels Oct 11, 2024
@github-actions github-actions bot added [Status] Priority Review Triggered Quality squad has been notified of this issue in #dotcom-triage-alerts [Platform] Simple labels Oct 11, 2024
@Robertght
Copy link
Author

📌 REPRODUCTION RESULTS

  • Tested on Simple – Replicated
  • Tested on Atomic – Could Not Replicate

📌 ACTIONS

  • Triaged
  • Replicated on Simple sites only.

@Robertght Robertght added Triaged To be used when issues have been triaged. and removed Needs triage Ticket needs to be triaged labels Oct 11, 2024
@tanjoymor
Copy link

tanjoymor commented Oct 12, 2024

Another report: 8762178-zd-a8c (Simple site)

This user also has the Settings > Newsletter option set to "Excerpt" as well as the Settings > Reading option. Their latest post email notification contained the full post.

Copy link

github-actions bot commented Oct 12, 2024

Support References

This comment is automatically generated. Please do not edit it.

  • 8762178-zen
  • 8854889-zen
  • 8894793-zen

@github-actions github-actions bot added the Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". label Oct 12, 2024
@inaikem inaikem closed this as completed Oct 13, 2024
@inaikem inaikem reopened this Oct 13, 2024
@ivan-ottinger
Copy link
Contributor

Previous ref: Automattic/jetpack#34372 (comment) cc @ivan-ottinger if you're still working on these

Thank you for the ping, Robert!

I am heading for AFKs so probably won't have enough bandwidth to take a deeper look at this issue this time, but someone from @Automattic/apex may be able to take a closer look.

When it comes to the issue itself, if I recall correctly, we have previously decoupled the RSS feed setting from the Newsletter's setting:

Image

These two settings should work separately: One for RSS only and one for email newsletter only.

@phcp phcp self-assigned this Oct 14, 2024
@phcp
Copy link
Contributor

phcp commented Oct 14, 2024

When it comes to the issue itself, if I recall correctly, we have previously decoupled the RSS feed setting from the Newsletter's setting:

Indeed, we have two site options: one for newsletters wpcom_subscription_emails_use_excerpt, and the other for RSS rss_use_excerpt. To set the newsletter option, the user must go to Settings > Newsletter.

This user also has the Settings > Newsletter option set to "Excerpt" as well as the Settings > Reading option. Their latest post email notification contained the full post.

The email excerpt works consistently in my tests with other simple sites. So, I checked this specific site, and the wpcom_subscription_emails_use_excerpt is missing in the database, so it defaults to the full-text email format. @tanjoymor, I can try switching it to full-text and then back to excerpt to verify that the option will be set correctly in the database. If it doesn't work, it may be related to the setting field or the settings API side and will require more research. How does that sound to you?

@tanjoymor
Copy link

@phcp apologies, I missed this ping. Yes that sounds good to me to try that.

@caitlindawn
Copy link

Reported in 8854889-zen

@Robertght
Copy link
Author

@phcp this appears to be already fixed in #95469 but I can see a new report here and in the other GH issue.

@lezama do you have a few minutes to review this further?

@Robertght
Copy link
Author

cc @supernovia for extra visibility

@devNigel
Copy link

Another report: 8894793-zd-a8c

@lezama
Copy link
Contributor

lezama commented Oct 21, 2024

Another report: 8894793-zd-a8c

Hey @devNigel, the screenshot the user provided is from before the fix, when picking "the excerpt" was still delivering the full post. I’ve checked it now, and the setting was correctly displaying as “Full Post.” I’ve already updated it to “Excerpt” for them.

@lezama
Copy link
Contributor

lezama commented Oct 21, 2024

Reported in 8854889-zd-a8c

@caitlindawn @Robertght I checked this user site and it has the setting set to "Full post" they need to set it as "Excerpt" to get back the "read more" links.

I tried clicking on "show excerpt", but that doesn't help. In the email, after the text it only gives "Comment" or "Like", not "Read post

Are they perhaps changing the RSS settings instead of the Newsletter settings?

@ariel-maidana
Copy link

@lezama I checked their newsletter settings and noticed they have them set to "Full text". I asked them to change it to "Excerpt".

@phcp phcp removed their assignment Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Feature Group] Content Management Features related to the tools and screens that admins use to manage their sites core content. [Feature] Site Content Emails All emails generated for new site content, like emails going out to subscribers. [Platform] Simple [Pri] High [Product] WordPress.com All features accessible on and related to WordPress.com. [Status] Priority Review Triggered Quality squad has been notified of this issue in #dotcom-triage-alerts Triaged To be used when issues have been triaged. [Type] Bug
Projects
Development

No branches or pull requests

9 participants