Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the call to formatCurrency to eliminate warnings in the plans page #95336

Closed
southp opened this issue Oct 14, 2024 · 2 comments
Closed
Assignees

Comments

@southp
Copy link
Contributor

southp commented Oct 14, 2024

Currently there are loads of formatCurrency warnings when visiting any page with the plans grid, e.g. the following screenshot was taken from the logged-in /plans:

Image

The warning is meant to highlight the calls that should be updated, so let's update the call accordingly to eliminate the warnings.

@jeyip
Copy link
Contributor

jeyip commented Oct 16, 2024

The warnings should be gone now #95369

@jeyip
Copy link
Contributor

jeyip commented Oct 16, 2024

I created a follow-up issue to investigate why the add-on cost calculations are re-rendered dozens of times for identical return values, even though the logic is memoized #95416

@jeyip jeyip closed this as completed Oct 16, 2024
@jeyip jeyip self-assigned this Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants