-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Passwordless Core Profiler Auth - Update disclaimer copy #95411
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~156 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests well with nit comments:
I think it was not related to this PR, but I'm seeing a small unintended extra spacing between the text below, which might be caused by the a
element. This was unnoticeable when there was only 2 lines, but the change made it visible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the copy is supposed to be By clicking [Button Text], you agree to our [Terms of Service](https://wordpress.com/tos/) and to [sync your site’s data](https://jetpack.com/redirect/?source=jetpack-support-what-data-does-jetpack-sync) with us.
, referring to the linked issue and the P2
Good question 🤔 I did not notice that. I updated the text according to Figma (Y5pUYSJPsGEud1vknUZhi8-fi-3182_10721) Let me confirm the copy. Update: Ah, it's a different copy :) I should also update Y5pUYSJPsGEud1vknUZhi8-fi-3182_14895 I'll work on it soon. Thank you for the catch 🙇 Update 2: Actually, it sounds like we're changing the copy text to: "By clicking [Button Text], you agree to our Terms of Service and agree to sync your site’s data with us" in all instances |
@rjchow Updated the copy in Update disclaimer copy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I tested Jetpack, WooPayments, and Core Profiler flows and they all looked ok. There's a prime mark which I've replaced with an apostrophe in the suggestion
Co-authored-by: RJ <27843274+rjchow@users.noreply.github.com>
332b1ed
to
08835e4
Compare
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/16927151 Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday. Hi @moon0326, could you please edit the description of this PR and add a screenshot for our translators? Ideally it'd include this string: Thank you in advance! |
Translation for this Pull Request has now been finished. |
This PR updates the disclaimer copy on the authorization page and move it above the button.
Issue: woocommerce/woocommerce#52047
Proposed Changes
Why are these changes being made?
Testing Instructions
config/development.json
and setwoocommerce/core-profiler-passwordless-auth
flag to trueyarn start
Pre-merge Checklist