Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passwordless Core Profiler Auth - Update disclaimer copy #95411

Merged
merged 5 commits into from
Oct 18, 2024

Conversation

moon0326
Copy link
Contributor

@moon0326 moon0326 commented Oct 15, 2024

This PR updates the disclaimer copy on the authorization page and move it above the button.

Issue: woocommerce/woocommerce#52047

Proposed Changes

  • Updated the disclaimer copy.
  • Moved the copy above the button.

Why are these changes being made?

  • To reflect the latest design change.

Testing Instructions

  1. Checkout this branch locally.
  2. Open config/development.json and set woocommerce/core-profiler-passwordless-auth flag to true
  3. Run yarn start
  4. Open this link
  5. Confirm the copy changes. Compare it to Y5pUYSJPsGEud1vknUZhi8-fi-3182_10721

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@moon0326 moon0326 requested review from a team, ilyasfoo and rjchow October 15, 2024 19:16
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Oct 15, 2024
@matticbot
Copy link
Contributor

matticbot commented Oct 15, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~156 bytes added 📈 [gzipped])

name             parsed_size           gzip_size
jetpack-connect      +1178 B  (+0.1%)     +156 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@ilyasfoo ilyasfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests well with nit comments:

I think it was not related to this PR, but I'm seeing a small unintended extra spacing between the text below, which might be caused by the a element. This was unnoticeable when there was only 2 lines, but the change made it visible.

image

Copy link
Contributor

@rjchow rjchow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the copy is supposed to be By clicking [Button Text], you agree to our [Terms of Service](https://wordpress.com/tos/) and to [sync your site’s data](https://jetpack.com/redirect/?source=jetpack-support-what-data-does-jetpack-sync) with us. , referring to the linked issue and the P2

@moon0326
Copy link
Contributor Author

moon0326 commented Oct 16, 2024

I think the copy is supposed to be By clicking [Button Text], you agree to our [Terms of Service](https://wordpress.com/tos/) and to [sync your site’s data](https://jetpack.com/redirect/?source=jetpack-support-what-data-does-jetpack-sync) with us. , referring to the linked issue and the P2

Good question 🤔 I did not notice that.

I updated the text according to Figma (Y5pUYSJPsGEud1vknUZhi8-fi-3182_10721) Let me confirm the copy.

Update: Ah, it's a different copy :) I should also update Y5pUYSJPsGEud1vknUZhi8-fi-3182_14895

I'll work on it soon. Thank you for the catch 🙇

Update 2: Actually, it sounds like we're changing the copy text to: "By clicking [Button Text], you agree to our Terms of Service and agree to sync your site’s data with us" in all instances

@moon0326
Copy link
Contributor Author

@rjchow Updated the copy in Update disclaimer copy

Copy link
Contributor

@rjchow rjchow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I tested Jetpack, WooPayments, and Core Profiler flows and they all looked ok. There's a prime mark which I've replaced with an apostrophe in the suggestion

client/jetpack-connect/disclaimer.jsx Outdated Show resolved Hide resolved
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/update-tos-copy on your sandbox.

@moon0326 moon0326 merged commit 3cee951 into trunk Oct 18, 2024
11 checks passed
@moon0326 moon0326 deleted the update/update-tos-copy branch October 18, 2024 18:43
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 18, 2024
@a8ci18n
Copy link

a8ci18n commented Oct 18, 2024

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/16927151

Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday.

Hi @moon0326, could you please edit the description of this PR and add a screenshot for our translators? Ideally it'd include this string: By clicking Connect your account, you agree to our {{termsOfServiceLink}}Terms of Service{{/termsOfServiceLink}} and to {{syncDataLink}}sync your site’s data{{/syncDataLink}} with us.

Thank you in advance!

@a8ci18n
Copy link

a8ci18n commented Oct 20, 2024

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants