Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A8C For Agencies: Fix Automattic typo #95423

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Conversation

sdnunca
Copy link
Contributor

@sdnunca sdnunca commented Oct 16, 2024

Related to #

Proposed Changes

  • This PR fixes a typo in A8C For Agencies.

Why are these changes being made?

Testing Instructions

  • Code review

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/a8c-for-agencies-typo on your sandbox.

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@sdnunca sdnunca requested a review from a team October 16, 2024 09:24
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 16, 2024
@sdnunca sdnunca merged commit 609d656 into trunk Oct 16, 2024
14 checks passed
@sdnunca sdnunca deleted the fix/a8c-for-agencies-typo branch October 16, 2024 09:24
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 16, 2024
@a8ci18n
Copy link

a8ci18n commented Oct 16, 2024

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/16911364

Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday.

Hi @sdnunca, could you please edit the description of this PR and add a screenshot for our translators? Ideally it'd include this string: Experience the rewards of selling Automattic products and hosting.

Thank you in advance!

@a8ci18n
Copy link

a8ci18n commented Oct 20, 2024

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants