Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reader: clean up scrolling on disabled onboarding modal #99181

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

Reader: clean up scrolling on disabled onboarding modal #99181

wants to merge 1 commit into from
+85 −72

Conversation

holdercp
Copy link
Contributor

@holdercp holdercp commented Jan 31, 2025 •
edited
Loading

Fixes #99135

Proposed Changes

  • Add a container around the onboarding subscriber modal to prevent scrolling when disabled

Before

Screen.Recording.2025-01-29.at.7.59.14.AM.mov

After

Screen.Recording.2025-01-31.at.3.26.47.PM.mov

Why are these changes being made?

  • Polish the UX

Testing Instructions

  • Create a new account that has an unverified email.
  • Nav to /read and start onboarding
  • When you get to the site subscription modal, make sure the content doesn't scroll. Check various breakpoints.
  • Verifiy your email and check for regressions

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@holdercp holdercp requested a review from a team as a code owner January 31, 2025 21:24
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 31, 2025
@holdercp holdercp self-assigned this Jan 31, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 31, 2025 •
edited by matticbot
Loading

Calypso Live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-131715
Jetpack Cloud live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-131715&env=jetpack
Automattic for Agencies live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-131715&env=a8c-for-agencies

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/reader-onboarding-scroll on your sandbox.

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~2 bytes removed 📉 [gzipped])

name    parsed_size           gzip_size
reader        +34 B  (+0.0%)       -2 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

DustyReagan
DustyReagan approved these changes Feb 1, 2025
View reviewed changes
Copy link
Member

@DustyReagan DustyReagan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well! It stops the scrolling on desktop and mobile, and I didn't find any regressions after verifying my email. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DustyReagan DustyReagan DustyReagan approved these changes

Assignees

@holdercp holdercp

Labels
[Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reader: Odd scrolling in onboarding site subscription step
3 participants
@holdercp @matticbot @DustyReagan