Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusion with music genres listed in "genres.json" #1

Open
polyarik opened this issue Sep 15, 2023 · 2 comments
Open

Confusion with music genres listed in "genres.json" #1

polyarik opened this issue Sep 15, 2023 · 2 comments

Comments

@polyarik
Copy link

polyarik commented Sep 15, 2023

I noticed that the genres.json file located in apps/core/assets/ doesn't include all the music genres out there.
Specifically, I couldn't find "City Pop" in the list. I was wondering if you plan to expand the list in the future or if you're sticking to a specific set of genres.

Also, some of the genres are listed multiple times but in slightly different spelling formats.
(e.g.: Post-Disco / Post Disco, Synthpunk / Synth Punk)
I'm not sure if this is intended or if it's an issue that needs to be addressed.

@Azarattum
Copy link
Owner

The file was sourced from an npm package and modified slightly. It is mostly used for title filtering, so it should be good enough. Different spelling is actually a good thing there.

@polyarik
Copy link
Author

Would you like me to add any music genres listed here that are not currently present in the genres.json file?
example

Additionally, I could sort the list alphabetically for easier reference :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants