Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme. Complete details in Cost Estimation section #366

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

elbruno
Copy link
Collaborator

@elbruno elbruno commented Sep 4, 2024

Purpose

  • Update readme. Complete details in Cost Estimation section.

Does this introduce a breaking change?

[ ] Yes
[X] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[X] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Get the code
  • Check the readme cost estimation section

Copy link
Collaborator

@luisquintanilla luisquintanilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @elbruno

@luisquintanilla luisquintanilla merged commit 34249a8 into main Sep 4, 2024
3 checks passed
@luisquintanilla luisquintanilla deleted the elbruno-update-cost-estimation-details branch September 4, 2024 19:29
@anfibiacreativa
Copy link
Member

anfibiacreativa commented Sep 9, 2024

@elbruno @luisquintanilla Please notice that this PR introduced a change that broke compliance (removing ##Guidance subheading)

@elbruno
Copy link
Collaborator Author

elbruno commented Sep 9, 2024

@elbruno @luisquintanilla Please notice that this PR introduced a change that broke compliance (removing ##Guidance subheading)

@anfibiacreativa "## Guidance" is required? Can you share the details of how this must be added to the main readme?. Glad to complete the Guidance section.

Best

PS: In the https://aka.ms/ragchat repo, the guidance includes the following sections. Is this was we should add here? We have the info, just need to add it. Thanks!

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants