Merge pull request #75 from Azure/dev

Applied feedback from broader audience

Author: jonlester

.github/workflows/docker-build-push.yml

@@ -36,10 +36,20 @@ Try it out by setting up a new AKS cluster with a sample application that uses E
 git clone https://github.com/Azure/EasyAuthForK8s.git
 cd EasyAuthForK8s
 
-# hint - run bash main.sh -h for parameter help
+# Hint - run bash main.sh -h for parameter help
+# Note: AAD app name (-a) must be *globally* unique
 # Note: Cluster name (-c) must be unique
-bash main.sh -a easy-auth-demo -c {insert-unique-hostname} -r easy-auth -e email@contoso.com -l eastus
+# Estimated Runtime: 15 minutes
+bash main.sh -a {insert-unique-app-name} -c {insert-unique-cluster-name} -r easy-auth -e email@contoso.com -l eastus
 ```
+What the quickstart script does:
+1) Deploy an AKS cluster
+2) Install an Nginx Ingress controller
+3) Configure DNS for the cluster public IP
+4) Register an AAD Application
+5) Install Cert Manager
+6) Deploy the Easy Auth Proxy
+7) Deploy the Application
 
 ## Documentation
 * [Setup Instructions](docs/setup-instructions.md) - step-by-step guide to building a cluster, configuring the ingress controller, and deploying an application protected by EasyAuth

.github/workflows/e2e-test.yml

@@ -247,7 +247,7 @@ kubectl get svc,deploy,pod
 For this sample app, we will use the sample application found in this repo
 
 ```
-kubectl run easyauth-sample-pod --image=docker.io/dakondra/eak-test-container:latest --expose --port=80
+kubectl run easyauth-sample-pod --image=docker.io/dakondra/eak-sample:latest --expose --port=80
 
 cat << EOF > ./sample-ingress.yaml
 apiVersion: networking.k8s.io/v1

.github/workflows/kubepug.yml

@@ -153,7 +153,7 @@ echo "BEGIN @ $(date +"%T"): Deploy sample app..."
 # If we have a parameter for an image install a custom image. If not, then we install kuard.
 if [ -z "$INPUTIMAGE" ]; then
     echo "No image input, installing sample."
-    kubectl run easyauth-sample-pod --image=docker.io/dakondra/eak-test-container:latest --expose --port=80
+    kubectl run easyauth-sample-pod --image=docker.io/dakondra/eak-sample:latest --expose --port=80
 else
     echo "Your custom image $INPUTIMAGE installed"
     kubectl run custom-pod --image=$INPUTIMAGE --expose --port=80

.github/workflows/main.yml

@@ -14,6 +14,8 @@ public IndexModel(ILogger<IndexModel> logger)
         }
         public void OnGet(string? encoding, string? format, string? prefix)
         {
+            try
+            {
                 if (!string.IsNullOrEmpty(encoding))
                     Encoding = encoding!;
                 if (!string.IsNullOrEmpty(format))
@@ -38,6 +40,11 @@ public void OnGet(string? encoding, string? format, string? prefix)
                 }
 
                 Headers.AddRange(headers.ToList());
+            }
+            catch (Exception ex)
+            {
+                // Do nothing, just don't throw an exception.
+            }
         }
         public List<KeyValuePair<string, string>> Headers = new();
         public string Encoding = "UrlEncode";

.github/workflows/pluto.yml

@@ -120,6 +120,7 @@ public struct AppManifestResult
         public bool Succeeded { get; set; } = false;
         public Exception? Exception { get; set; } = null;
         public AppManifest? AppManifest { get; set; } = null;
+        public AppManifestResult() {  }
     }