Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] "WARNING mounting DVD failed" when provisioning agent crashes and is restarted #1456

Open
jasonzio opened this issue Feb 4, 2019 · 0 comments

Comments

@jasonzio
Copy link
Member

jasonzio commented Feb 4, 2019

Describe the bug
When the provisioning agent starts, its first action is to capture the ovf.xml file. The specific sequence of operations:

  • mount the dvd
  • read the ovf.xml file from the dvd
  • write the (redacted) ovf.xml file to disk
  • umount the dvd
  • eject the dvd

This is a non-idempotent sequence of operations. If the provisioning agent crashes before completing provisioning, it gets restarted, but the attempt to mount the dvd fails because it has been ejected.

The "eject the dvd" operation should be deferred until after provisioning is complete.

Distro and WALinuxAgent details (please complete the following information):

  • CemtOS 7.5 and earlier
  • WALinuxAgent version is unknown but older than 2.2.34

Additional context
Unfortunately, the "cannot mount dvd" handler cannot just use the copy of ovf.xml written to disk by the first (failed) instance of the provisioning agent because the agent password has been redacted from the copy written to disk.

@jasonzio jasonzio added the triage Needs Triaging label Feb 4, 2019
@jasonzio jasonzio changed the title [BUG] "Can't mount dvd" when provisioning agent crashes and is restarted [BUG] "WARNING mounting DVD failed" when provisioning agent crashes and is restarted Feb 5, 2019
@jasonzio jasonzio assigned jasonzio and unassigned vrdmr, narrieta and pgombar Feb 5, 2019
@jasonzio jasonzio added bug provisioning and removed triage Needs Triaging labels Feb 5, 2019
@AOhassan AOhassan mentioned this issue May 16, 2019
6 tasks
@jasonzio jasonzio assigned AOhassan and unassigned jasonzio May 21, 2019
@narrieta narrieta assigned trstringer and unassigned AOhassan Oct 29, 2019
@trstringer trstringer removed their assignment Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants