Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhanced GitHub Actions workflows for Terraform #42

Open
tjcorr opened this issue Jun 23, 2022 · 3 comments · May be fixed by #59
Open

Enhanced GitHub Actions workflows for Terraform #42

tjcorr opened this issue Jun 23, 2022 · 3 comments · May be fixed by #59
Assignees
@tjcorr

Comments

@tjcorr
Copy link
Collaborator

tjcorr commented Jun 23, 2022

I've been working on some reference workflows for terraform at: https://github.com/tjcorr/tf-pipeline-demo

They add some nice features like:

  • Pausing for manual approvals
  • Using OIDC to eliminate credentials
  • Output Terraform Plans to PR comments and task summaries
  • A nightly drift detection job that creates issues if anything detected
  • Terraform unit tests

Would this project be interested in looking at these changes and merging them in? I'm happy to help with a PR but wanted to validate the idea first.
@tjcorr
Copy link
Collaborator Author

tjcorr commented Jun 23, 2022

I'm also working on something similar for bicep at: https://github.com/tjcorr/bicep-pipeline-demo

@Gordonby
Copy link
Contributor

If you want some inspiration for the bicep one, here's what the AKS-Construction one looks like;

It deploys different known good smoke test apps in increasing complexity.
It also runs a troubleshooting stage to inspect logs and events on the cluster/fw.

image

https://github.com/Azure/AKS-Construction/actions/runs/2545655202

@bahramr
Copy link
Collaborator

bahramr commented Jul 18, 2022

Hi @tjcorr, yes we should definitely incorporate your code into this reference implementation to maximize the number of people who may get to use it. Let's work together on it.

@tjcorr tjcorr linked a pull request Aug 24, 2022 that will close this issue
Draft
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tjcorr tjcorr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[WIP] Add improved terraform and bicep workflows tjcorr/aks-baseline-automation
3 participants
@tjcorr @bahramr @Gordonby