DNS logs will contain error rather than actual pod error visibility. (#117)

Author: Tatsinnit

pkg/collector/dns_collector.go

@@ -24,14 +24,14 @@ func (collector *DNSCollector) GetName() string {
 func (collector *DNSCollector) Collect() error {
 	output, err := utils.ReadFileContent("/etchostlogs/resolv.conf")
 	if err != nil {
-		return err
+		output = err.Error()
 	}
 
 	collector.data["virtualmachine"] = output
 
 	output, err = utils.ReadFileContent("/etc/resolv.conf")
 	if err != nil {
-		return err
+		output = err.Error()
 	}
 
 	collector.data["kubernetes"] = output

pkg/collector/dns_collector_test.go

@@ -0,0 +1,34 @@
+package collector
+
+import (
+	"testing"
+)
+
+func TestNewDNSCollector(t *testing.T) {
+	tests := []struct {
+		name    string
+		want    int
+		wantErr bool
+	}{
+		{
+			name:    "get dns logs",
+			want:    1,
+			wantErr: false,
+		},
+	}
+
+	c := NewDNSCollector()
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			err := c.Collect()
+			if (err != nil) != tt.wantErr {
+				t.Errorf("Collect() error = %v, wantErr %v", err, tt.wantErr)
+			}
+			raw := c.GetData()
+			if len(raw) < tt.want {
+				t.Errorf("len(GetData()) = %v, want %v", len(raw), tt.want)
+			}
+		})
+	}
+}