-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Could we remove this functional token? #11431
Comments
add it to S163 |
@haroldrandom Please take a look at these two lines azure-cli/CredScanSuppressions.json Line 285 in 807facc
azure-cli/CredScanSuppressions.json Line 293 in 807facc
|
I think it should own by service team. The accessToken is used in test_ams_live_event_scenarios.py is hard coded. Should be get online through command. Added "Service Attension" for further help. |
@fredericky @akucer @yulei, could you please help with above hard coded accessToken issue from Media Services team? |
Add an example #12589 (comment) |
The accessToken is used in test_ams_live_event_scenarios.py is actually named poorly because it is a GUID and not an actual security token. I have updated the code to use a generated GUID instead of a hardcoded one in order to avoid confusion: #13948. The second hardcoded string is found in the container module and AMS does not own that. |
Add one related issue Azure/azure-cli-dev-tools#215 |
@haroldrandom - I removed the Media Services label and assignment to AMS team members as AMS issue has been fixed. As per previous comment the other hardcoded string is not owned by AMS and needs assignment to appropriate team / owner. Thanks. |
Is your feature request related to a problem? Please describe.
Looks like this token is still valid and we should remove it.
The text was updated successfully, but these errors were encountered: