Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could we remove this functional token? #11431

Closed
mmyyrroonn opened this issue Nov 29, 2019 · 8 comments
Closed

Could we remove this functional token? #11431

mmyyrroonn opened this issue Nov 29, 2019 · 8 comments
Assignees
Labels
feature-request Service Attention This issue is responsible by Azure service team. Test Framework
Milestone

Comments

@mmyyrroonn
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Looks like this token is still valid and we should remove it.

@haroldrandom
Copy link
Contributor

add it to S163

@mmyyrroonn
Copy link
Contributor Author

@haroldrandom Please take a look at these two lines

"placeholder": "0abf356884d74b4aacbd7b1ebd3da0f7",
and
"placeholder": "5+36OCtbIwfy8g5glC4bQQrFsfmMc3iD",

@haroldrandom haroldrandom modified the milestones: S163, S165 Dec 20, 2019
@yonzhan yonzhan modified the milestones: S165, S166 Feb 15, 2020
@haroldrandom
Copy link
Contributor

haroldrandom commented Feb 23, 2020

I think it should own by service team. The accessToken is used in test_ams_live_event_scenarios.py is hard coded. Should be get online through command.

Added "Service Attension" for further help.

@haroldrandom haroldrandom added Media Services az ams Service Attention This issue is responsible by Azure service team. labels Feb 23, 2020
@yonzhan
Copy link
Collaborator

yonzhan commented Feb 23, 2020

@fredericky @akucer @yulei, could you please help with above hard coded accessToken issue from Media Services team?

@yonzhan yonzhan added Service Attention This issue is responsible by Azure service team. and removed Service Attention This issue is responsible by Azure service team. labels Feb 23, 2020
@yonzhan yonzhan modified the milestones: S166, Backlog Mar 7, 2020
@haroldrandom
Copy link
Contributor

Add an example #12589 (comment)

@hivyas
Copy link
Member

hivyas commented Jun 12, 2020

The accessToken is used in test_ams_live_event_scenarios.py is actually named poorly because it is a GUID and not an actual security token. I have updated the code to use a generated GUID instead of a hardcoded one in order to avoid confusion: #13948.

The second hardcoded string is found in the container module and AMS does not own that.

@haroldrandom
Copy link
Contributor

Add one related issue Azure/azure-cli-dev-tools#215

@akucer akucer unassigned giakas and hivyas Sep 11, 2020
@akucer akucer removed the Media Services az ams label Sep 11, 2020
@akucer
Copy link

akucer commented Sep 11, 2020

@haroldrandom - I removed the Media Services label and assignment to AMS team members as AMS issue has been fixed. As per previous comment the other hardcoded string is not owned by AMS and needs assignment to appropriate team / owner. Thanks.

@bebound bebound closed this as completed Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Service Attention This issue is responsible by Azure service team. Test Framework
Projects
None yet
Development

No branches or pull requests

9 participants