Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default Application Name to connections #597

Open
Charles-Gagnon opened this issue Dec 20, 2022 · 2 comments
Open

Add default Application Name to connections #597

Charles-Gagnon opened this issue Dec 20, 2022 · 2 comments
Labels
enhancement New feature or request P1
Milestone

Comments

@Charles-Gagnon
Copy link
Contributor

Currently we don't specify an Application Name, which means that unless the user specifies one themselves it will just show up as something generic like this :

Core Microsoft SqlClient Data Provider

which isn't very useful.

Users can always specify it themselves in their connection string, but the downside of this is that there's no easy way to tell which connection is for what purpose (and we make a number of connections, especially for the trigger).

So the first question is whether we should do anything about this at all - or just let people specify an Application Name themselves if they want.

Some other options if we do want to add it :

  1. Assign a name ourselves to each connection, overwriting whatever the user may have specified
  2. Check if the user already passed in a name - and if so then do nothing (leave it as-is)
  3. Check if the user already passed in a name - and if so then use that name but append a specifier to the end to signify what the connection is doing. If none provided have a default value for each connection.
@Charles-Gagnon Charles-Gagnon added the enhancement New feature or request label Dec 20, 2022
@Charles-Gagnon
Copy link
Contributor Author

@dzsquared Do you have any thoughts on this?

@dzsquared
Copy link
Contributor

  • if the user configures an application name, don't alter it
  • if the user doesn't configure an application name, it's nice but not required that we provide more useful information - either the connector ("Azure SQL bindings for Azure Functions") or the Azure app name (I don't think we can get this within the app)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P1
Projects
None yet
Development

No branches or pull requests

3 participants