You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Furthermore, other than the getting started docs, no one is referencing vcpkg-commit.txt. It is useful to keep to make documenting easier and having a single place to update the baseline we point to. We should make use of that in the AzureVcpkg.cmake module and vcpkg.json file (for the baseline), OR remove it.
We should ideally use this string in one place. Having it in a single text file makes it easier to read for users and automation (as opposed to extracting it from a cmake file). I vote we have the cmake script read it from a file if it's easy enough to do.
Reading it from a file within cmake is doable (https://cmake.org/cmake/help/latest/command/file.html), but the issue is with updating that same string within the "builtin-baseline" property within the vcpkg.json file.
As an aside, the C++ SDK repo doesn't have the vcpkg-commit.txt file, how does it extract the SHA to check-out?
There are no users of the
vcpkg.ps1
script:azure-sdk-for-c/eng/scripts/vcpkg.ps1
Line 1 in 070162c
Furthermore, other than the getting started docs, no one is referencing
vcpkg-commit.txt
. It is useful to keep to make documenting easier and having a single place to update the baseline we point to. We should make use of that in theAzureVcpkg.cmake
module andvcpkg.json
file (for the baseline), OR remove it.azure-sdk-for-c/eng/vcpkg-commit.txt
Line 1 in 070162c
https://github.com/Azure/azure-sdk-for-c/blob/2e375c04b00c36c9b024afbcd405d348732b1142/sdk/samples/iot/README.md#prerequisites
azure-sdk-for-c/cmake-modules/AzureVcpkg.cmake
Line 24 in 070162c
azure-sdk-for-c/vcpkg.json
Line 4 in 070162c
cc @vhvb1989, @danieljurek, @BillyONeal, @danewalton
The text was updated successfully, but these errors were encountered: