Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for SAS tokens in Tables to encourage SFI best practices #6307

Open
ahsonkhan opened this issue Dec 17, 2024 · 0 comments · May be fixed by #6311
Open

Remove support for SAS tokens in Tables to encourage SFI best practices #6307

ahsonkhan opened this issue Dec 17, 2024 · 0 comments · May be fixed by #6311
Assignees
Labels
Milestone

Comments

@ahsonkhan
Copy link
Member

Based on offline discussion with @JeffreyRichter and @gearama, and SFI guidance, we can remove the AzureSasCredential ctor overload and wait for customer requests for it before adding it. For security best practices, we'd want to steer customers to the pit of success.

Consider removing this ctor along with any other types that would no longer be needed as a result. Leveraging expertise as the SDK owner, we'd want to validate that no known customer scenario is blocked when we do this.

/**
* @brief Initializes a new instance of tableClient.
*
* @param serviceUrl The service Url
* @param credential The SAS credential used to sign requests.
* @param tableName The name of the table.
* @param options Optional client options that define the transport pipeline policies for
* authentication, retries, etc., that are applied to every request.
*/
explicit TableClient(
const std::string& serviceUrl,
std::shared_ptr<Azure::Data::Tables::Credentials::AzureSasCredential> credential,
const std::string& tableName,
const TableClientOptions& options = {});

For example, this means, we'd no longer have callers for NamedKeyCredential or the SAS builder helpers, so we can remove them as well (for now). They can always get added back in the future, but we can't take them away if we GA with them.

Related: #6143

@RickWinter RickWinter added the blocking-release Blocks release label Dec 17, 2024
@RickWinter RickWinter added this to the 2025-01 milestone Dec 17, 2024
@gearama gearama linked a pull request Dec 23, 2024 that will close this issue
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants