From 0c94d5a517d6530d3a37f633ec62438b21fc37c8 Mon Sep 17 00:00:00 2001
From: Matthew Christopher <matthchr@microsoft.com>
Date: Tue, 20 Apr 2021 14:52:23 -0700
Subject: [PATCH] Make AzureSQL KeyVault secret deletion best effort (#1412)

- It already was best effort in most places but we missed one.
---
 .../azuresql/azuresqluser/azuresqluser_reconcile.go         | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/pkg/resourcemanager/azuresql/azuresqluser/azuresqluser_reconcile.go b/pkg/resourcemanager/azuresql/azuresqluser/azuresqluser_reconcile.go
index 435e6dc5411..8b0f0bb8460 100644
--- a/pkg/resourcemanager/azuresql/azuresqluser/azuresqluser_reconcile.go
+++ b/pkg/resourcemanager/azuresql/azuresqluser/azuresqluser_reconcile.go
@@ -251,13 +251,11 @@ func (s *AzureSqlUserManager) Ensure(ctx context.Context, obj runtime.Object, op
 			}
 		}
 
-		err = userSecretClient.Delete(
+		// Purposefully ignoring error here for now
+		userSecretClient.Delete(
 			ctx,
 			userSecretKey,
 			secrets.Flatten(true, toDelete...))
-		if err != nil {
-			return false, err
-		}
 
 		err = userSecretClient.Upsert(
 			ctx,