From e481f6b3229fd7536180edd69790d3e067e4bb97 Mon Sep 17 00:00:00 2001 From: Bevan Arps <bevan.arps@microsoft.com> Date: Tue, 3 Dec 2024 17:54:09 +1300 Subject: [PATCH] Ensure simple logger shuts down properly (#4473) --- v2/cmd/asoctl/pkg/importreporter/log.go | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/v2/cmd/asoctl/pkg/importreporter/log.go b/v2/cmd/asoctl/pkg/importreporter/log.go index e85e9f92166..125c23e6ea5 100644 --- a/v2/cmd/asoctl/pkg/importreporter/log.go +++ b/v2/cmd/asoctl/pkg/importreporter/log.go @@ -47,9 +47,14 @@ func newLogProgress( total += int64(delta.pending) // If we're done, finish up - if parent == nil && total > 0 && completed >= total { - // We're the root importreporter log, so we also need to handle the done channel - close(done) + if total > 0 && completed >= total { + close(result.updates) + + if parent == nil { + // We're the root importreporter log, so we also need to handle the done channel + close(done) + } + break }