Skip to content

Commit d4d59de

Browse files
End of call survey UI change (#3951)
* ui change * Change files * Duplicate change files for beta release * Update packages/react-composites CallComposite browser test snapshots --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
1 parent 02c8d42 commit d4d59de

18 files changed

+40
-10
lines changed
Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
{
2+
"type": "prerelease",
3+
"area": "feature",
4+
"workstream": "Modify end of call survey UI based on post bug bash suggestions",
5+
"comment": "ui change",
6+
"packageName": "@azure/communication-react",
7+
"email": "96077406+carocao-msft@users.noreply.github.com",
8+
"dependentChangeType": "patch"
9+
}
Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
{
2+
"type": "prerelease",
3+
"area": "feature",
4+
"workstream": "Modify end of call survey UI based on post bug bash suggestions",
5+
"comment": "ui change",
6+
"packageName": "@azure/communication-react",
7+
"email": "96077406+carocao-msft@users.noreply.github.com",
8+
"dependentChangeType": "patch"
9+
}

packages/react-components/src/components/Survey/StarSurvey/StarSurvey.styles.ts

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import { _pxToRem } from '@internal/acs-ui-common';
1010
export const helperTextStyle = (theme: Theme): string =>
1111
mergeStyles({
1212
fontWeight: 600,
13-
fontSize: _pxToRem(14),
13+
fontSize: _pxToRem(16),
1414
lineHeight: _pxToRem(20),
1515
color: theme.palette.neutralPrimary,
1616
paddingTop: _pxToRem(20)
@@ -36,10 +36,18 @@ export const ratingHelperTextStyle = (theme: Theme): string =>
3636
export const ratingStyles = (theme: Theme): Partial<IRatingStyles> => {
3737
return {
3838
root: {
39-
textAlign: 'center'
39+
textAlign: 'center',
40+
height: 'auto',
41+
marginTop: _pxToRem(8)
42+
},
43+
ratingStarIsLarge: {
44+
height: 'auto',
45+
padding: 0
4046
},
4147
ratingStar: {
42-
transform: 'scale(1.15)'
48+
transform: 'scale(1.2)',
49+
margin: _pxToRem(6),
50+
height: 'auto'
4351
},
4452
ratingStarFront: {
4553
color: theme.palette.themePrimary

packages/react-components/src/components/Survey/TagsSurvey/TagsSurvey.styles.ts

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import { _pxToRem } from '@internal/acs-ui-common';
1010
export const questionTextStyle = (theme: Theme): string =>
1111
mergeStyles({
1212
fontWeight: 600,
13-
fontSize: _pxToRem(14),
13+
fontSize: _pxToRem(16),
1414
lineHeight: _pxToRem(20),
1515
color: theme.palette.neutralPrimary,
1616
paddingTop: _pxToRem(20)
@@ -24,7 +24,7 @@ export const helperTextStyle = (theme: Theme): string =>
2424
fontWeight: 400,
2525
fontSize: _pxToRem(12),
2626
lineHeight: _pxToRem(16),
27-
color: theme.palette.neutralPrimary
27+
color: theme.palette.neutralSecondary
2828
});
2929

3030
/**
@@ -40,8 +40,7 @@ export const checkboxClassName = mergeStyles({
4040
*/
4141
export const freeFormTextCheckboxStyles: Partial<ICheckboxStyles> = {
4242
root: {
43-
padding: _pxToRem(8),
44-
paddingLeft: 0,
43+
paddingBottom: _pxToRem(8),
4544
width: '100%'
4645
},
4746
label: {
@@ -53,5 +52,9 @@ export const freeFormTextCheckboxStyles: Partial<ICheckboxStyles> = {
5352
* @private
5453
*/
5554
export const freeFormTextFieldClassName = mergeStyles({
56-
width: '100%'
55+
width: '100%',
56+
marginLeft: _pxToRem(4),
57+
input: {
58+
padding: 0
59+
}
5760
});

packages/react-components/src/components/Survey/TagsSurvey/TagsSurvey.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -196,7 +196,6 @@ export const _TagsSurvey = (props: _TagsSurveyProps): JSX.Element => {
196196
<>
197197
<Stack verticalAlign="center">
198198
<Text className={questionTextStyle(theme)}>{strings?.tagsSurveyQuestion}</Text>
199-
<Text className={helperTextStyle(theme)}>{strings?.tagsSurveyHelperText}</Text>
200199
</Stack>
201200

202201
<Pivot>
@@ -234,6 +233,8 @@ export const _TagsSurvey = (props: _TagsSurveyProps): JSX.Element => {
234233
);
235234
})}
236235
</Pivot>
236+
237+
<Text className={helperTextStyle(theme)}>{strings?.tagsSurveyHelperText}</Text>
237238
</>
238239
);
239240
};

packages/react-composites/src/composites/common/SurveyPane.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ export const SurveyPane = (props: {
5757
() => (
5858
<>
5959
{showSubmitFeedbackButton && (
60-
<Stack style={{ borderTop: 'solid', borderTopColor: 'lightgrey' }} horizontalAlign="end">
60+
<Stack horizontalAlign="end">
6161
<PrimaryButton
6262
style={{ marginTop: '1rem' }}
6363
onClick={() => {

0 commit comments

Comments
 (0)