Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[runner subcmd] support -v flag for run #32

Closed
Tracked by #3
fuweid opened this issue Jan 9, 2024 · 0 comments · Fixed by #45
Closed
Tracked by #3

[runner subcmd] support -v flag for run #32

fuweid opened this issue Jan 9, 2024 · 0 comments · Fixed by #45

Comments

@fuweid
Copy link
Collaborator

fuweid commented Jan 9, 2024

Background

Currently, kperf runner run uses client-go pkg to send requests.
We should use https://pkg.go.dev/k8s.io/klog/v2 to enable debug log for request.
It's helpful to verify request's URL is expected.

Plan

Add -v, number for the log level verbosity flag to run subcommand.

Use klog utils to set log level.

REF: https://github.com/kubernetes/klog/blob/2086216a5034ba7c4e3a4fec7d89c5d0434eb1a0/examples/set_output/usage_set_output.go#L13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants