From ef2977bc6a0cc3a2e2aba8cacba1056c43532330 Mon Sep 17 00:00:00 2001 From: Ariz Zubair <5427064+az-pz@users.noreply.github.com> Date: Fri, 16 Jan 2026 13:41:23 -0500 Subject: [PATCH] Enable sff_mgr for all non-cmis txvrs (#719) Update the unit tests. --- sonic-xcvrd/tests/test_xcvrd.py | 1 - sonic-xcvrd/xcvrd/sff_mgr.py | 10 ++-------- 2 files changed, 2 insertions(+), 9 deletions(-) diff --git a/sonic-xcvrd/tests/test_xcvrd.py b/sonic-xcvrd/tests/test_xcvrd.py index 53e5f14..852872e 100644 --- a/sonic-xcvrd/tests/test_xcvrd.py +++ b/sonic-xcvrd/tests/test_xcvrd.py @@ -2274,7 +2274,6 @@ def test_SffManagerTask_task_worker(self, mock_chassis, mock_logger): mock_xcvr_api.is_flat_memory.call_count = 0 task.task_stopping_event.is_set = MagicMock(side_effect=[False, False, True]) task.task_worker() - assert mock_xcvr_api.is_flat_memory.call_count == 1 assert mock_xcvr_api.tx_disable_channel.call_count == 2 mock_xcvr_api.is_flat_memory = MagicMock(return_value=False) diff --git a/sonic-xcvrd/xcvrd/sff_mgr.py b/sonic-xcvrd/xcvrd/sff_mgr.py index 3cc5404..40e6e39 100644 --- a/sonic-xcvrd/xcvrd/sff_mgr.py +++ b/sonic-xcvrd/xcvrd/sff_mgr.py @@ -366,8 +366,8 @@ def task_worker(self): # Skip if these essential routines are not available continue - # Procced only for QSFP28/QSFP+ transceiver - if not (xcvr_type.startswith('QSFP28') or xcvr_type.startswith('QSFP+')) or xcvrd.is_cmis_api(api): + # Proceed only for non-cmis transceiver + if xcvrd.is_cmis_api(api): continue # Handle the case that host_tx_ready value in the local cache hasn't @@ -422,12 +422,6 @@ def task_worker(self): data[self.ADMIN_STATUS], admin_status_changed)) try: - # Skip if it's not a paged memory device - if api.is_flat_memory(): - self.log_notice( - "{}: skipping sff_mgr for flat memory xcvr".format(lport)) - continue - # Skip if it's a copper cable if api.is_copper(): self.log_notice(