feat: role assignments at mg scope #187
Draft
+376
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
the
Needs: Triage 🔍
matt-FFFFFF
changed the title
There was a problem hiding this comment.
PR Overview
This pull request adds the ability to assign roles at the management group scope.
- Introduces new examples and documentation for management group role assignments.
- Updates the module README to document new inputs and configuration options for role assignments.
- Adds YAML test definitions for architecture and archetype validation.
Reviewed Changes
| File | Description |
|---|---|
| examples/role-assignments/README.md | New example demonstrating role assignments using a dedicated management group module. |
| README.md | Updated module documentation with new inputs and resource references for role assignments. |
| examples/role-assignments/lib/test.alz_architecture_definition.yml | Added YAML test definitions for management group configuration. |
| examples/default/README.md | Updated provider configuration to include library override settings. |
| examples/role-assignments/lib/test.alz_archetype_definition.yml | New archetype definition file with sample role definitions. |
| examples/role-assignments/_header.md | New header file with a brief description of the role assignments example. |
Copilot reviewed 19 out of 19 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
README.md:775
- [nitpick] The naming 'role_assignment' here differs from the previously used 'role_assignments' (line 648). If these blocks represent similar configurations, consider standardizing the naming for clarity, or update the documentation to explain the distinction.
role_assignment = optional(object({
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add requested feature to be able to assign roles to management groups
fixes: