Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular: acquireTokenRedirect is not actually called by the interceptor on error #6282

Closed
submarines-and opened this issue Aug 2, 2023 · 1 comment
Assignees
Labels
bug-unconfirmed A reported bug that needs to be investigated and confirmed msal-angular Related to @azure/msal-angular package msal-browser Related to msal-browser package public-client Issues regarding PublicClientApplications question Customer is asking for a clarification, use case or information.

Comments

@submarines-and
Copy link

submarines-and commented Aug 2, 2023

Core Library

MSAL.js (@azure/msal-browser)

Core Library Version

2.38.0

Wrapper Library

MSAL Angular (@azure/msal-angular)

Wrapper Library Version

2.5.9

Public or Confidential Client?

Public

Description

acquireTokenRedirect is an observable and needs to be subscribed to fire. In the code, it needs a "return" statement before it, as it is now, nothing happens.

See code here:
https://github.com/AzureAD/microsoft-authentication-library-for-js/blob/dev/lib/msal-angular/src/msal.interceptor.ts#L207

Error Message

Affects any error that requires interaction

Msal Logs

N/A

MSAL Configuration

{
}

Relevant Code Snippets

https://github.com/AzureAD/microsoft-authentication-library-for-js/blob/dev/lib/msal-angular/src/msal.interceptor.ts#L207

Reproduction Steps

Cause any error that requires interaction

Expected Behavior

User should be redirected

Identity Provider

Azure AD / MSA

Browsers Affected (Select all that apply)

Chrome, Edge, Safari

Regression

No response

Source

External (Customer)

@submarines-and submarines-and added bug-unconfirmed A reported bug that needs to be investigated and confirmed question Customer is asking for a clarification, use case or information. labels Aug 2, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Attention 👋 Awaiting response from the MSAL.js team label Aug 2, 2023
@github-actions github-actions bot added msal-angular Related to @azure/msal-angular package msal-browser Related to msal-browser package public-client Issues regarding PublicClientApplications labels Aug 2, 2023
@submarines-and
Copy link
Author

Caused by this:
#4176

Very frustrating, but it works when Broadcast service is added to dependencies

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Attention 👋 Awaiting response from the MSAL.js team and removed Needs: Attention 👋 Awaiting response from the MSAL.js team labels Aug 3, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs: Attention 👋 Awaiting response from the MSAL.js team label Aug 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-unconfirmed A reported bug that needs to be investigated and confirmed msal-angular Related to @azure/msal-angular package msal-browser Related to msal-browser package public-client Issues regarding PublicClientApplications question Customer is asking for a clarification, use case or information.
Projects
None yet
Development

No branches or pull requests

2 participants