Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The documentation for the type BrowserSystemOptions is not available #6283

Closed
dirthsj opened this issue Aug 2, 2023 · 5 comments
Closed

The documentation for the type BrowserSystemOptions is not available #6283

dirthsj opened this issue Aug 2, 2023 · 5 comments
Assignees
@jo-arroyo
Labels
answered Question has received "first qualified response" documentation Related to documentation. msal-browser Related to msal-browser package public-client Issues regarding PublicClientApplications question Customer is asking for a clarification, use case or information.

Comments

@dirthsj
Copy link

dirthsj commented Aug 2, 2023

Core Library

MSAL.js (@azure/msal-browser)

Wrapper Library

MSAL Angular (@azure/msal-angular)

Public or Confidential Client?

Public

Documentation Location

https://azuread.github.io/microsoft-authentication-library-for-js/ref/modules/_azure_msal_browser.html#browsersystemoptions

Description

Other types on this page have useful descriptions of their contents. BrowserSystemOptions does not.
@dirthsj dirthsj added documentation Related to documentation. question Customer is asking for a clarification, use case or information. labels Aug 2, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Attention 👋 Awaiting response from the MSAL.js team label Aug 2, 2023
@github-actions github-actions bot added msal-angular Related to @azure/msal-angular package msal-browser Related to msal-browser package public-client Issues regarding PublicClientApplications labels Aug 2, 2023
@hectormmg
Copy link
Member

@dirthsj for some reason it seems typedoc isn't picking up the attribute descriptions, I'll look into it. Thanks for pointing this out!

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Author Feedback Awaiting response from issue author and removed Needs: Attention 👋 Awaiting response from the MSAL.js team labels Aug 2, 2023
@microsoft-github-policy-service
Copy link
Contributor

@dirthsj This issue has been automatically marked as stale because it is marked as requiring author feedback but has not had any activity for 5 days. If your issue has been resolved please let us know by closing the issue. If your issue has not been resolved please leave a comment to keep this open. It will be closed automatically in 7 days if it remains stale.

@microsoft-github-policy-service microsoft-github-policy-service bot added the no-issue-activity Issue author has not responded in 5 days label Aug 8, 2023
@dirthsj
Copy link
Author

dirthsj commented Aug 8, 2023

This comment is to prevent the bot from closing the issue automatically.

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Attention 👋 Awaiting response from the MSAL.js team and removed Needs: Author Feedback Awaiting response from issue author labels Aug 8, 2023
@hectormmg hectormmg assigned jo-arroyo and unassigned hectormmg Aug 8, 2023
@jo-arroyo jo-arroyo added bug A problem that needs to be fixed for the feature to function as intended. and removed question Customer is asking for a clarification, use case or information. msal-angular Related to @azure/msal-angular package no-issue-activity Issue author has not responded in 5 days Needs: Attention 👋 Awaiting response from the MSAL.js team labels Aug 9, 2023
@tnorling
Copy link
Collaborator

@dirthsj Can you take another look? https://azuread.github.io/microsoft-authentication-library-for-js/ref/types/_azure_msal_browser.BrowserSystemOptions.html

@tnorling tnorling added question Customer is asking for a clarification, use case or information. answered Question has received "first qualified response" Needs: Author Feedback Awaiting response from issue author and removed bug A problem that needs to be fixed for the feature to function as intended. labels Aug 10, 2023
@dirthsj
Copy link
Author

dirthsj commented Aug 10, 2023

Looks good to me! Thanks for quick turn around.

@dirthsj dirthsj closed this as completed Aug 10, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Attention 👋 Awaiting response from the MSAL.js team label Aug 10, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot removed Needs: Attention 👋 Awaiting response from the MSAL.js team Needs: Author Feedback Awaiting response from issue author labels Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jo-arroyo jo-arroyo

Labels
answered Question has received "first qualified response" documentation Related to documentation. msal-browser Related to msal-browser package public-client Issues regarding PublicClientApplications question Customer is asking for a clarification, use case or information.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@dirthsj @hectormmg @tnorling @jo-arroyo