Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rhinoceros_Toolkit: Converts for NurbsSurfaces with trims #163

Open
kThorsager opened this issue May 26, 2020 · 1 comment
Open

Rhinoceros_Toolkit: Converts for NurbsSurfaces with trims #163

kThorsager opened this issue May 26, 2020 · 1 comment
Assignees
Labels
type:bug Error or unexpected behaviour

Comments

@kThorsager
Copy link
Contributor

Description:

NurbsSurfaces with outer trims.

If a NurbsSurface outer trim has a Ellipse or Circle as its outer surface trim it can't be converted back to Rhino after being in the BHoM.

Fairly sure it's because rhino checks the trims for closeness, but ellipses and circles don't have start/endpoints where the trim expects it and hence fails.

i.e. Rhino sends the trim over as nurbs curve, BHoM makes it into a Circle/Ellipse and loses the start/end, BHoM sends over the curves, Rhino checks if the curve is closed and can't find them.

Think always keeping trims as Nurbs should fix this?
@epignatelli

Steps to reproduce:

see test file

Expected behaviour:

I'd like to convert back and forth between Rhino and BHoM

Test file(s):

https://burohappold.sharepoint.com/:u:/s/BHoM/EZXSnjChE6hJiaKi-ZfpHmMBACb1U_cZjMPaZ9OhUjGrOA?e=GRjPNL

@kThorsager kThorsager added the type:bug Error or unexpected behaviour label May 26, 2020
@michaelhoehn
Copy link
Contributor

I can have a look at this one in the coming 7.1 milestone.

@michaelhoehn michaelhoehn self-assigned this Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

No branches or pull requests

2 participants