FrameGraph: add new volumetric lighting task #17515

Popov72 · 2025-11-27T18:36:20Z

Also in this PR:

Fix crash when depth/stencil attachment has no depth in WebGPU
Slightly refactor IStencilState
Fix wrong error message when the last disabled pass is not a render pass
LightingVolume: Fix crash in WebGL when updating the buildFullVolume property

[UPDATE] I added the NRG blocks corresponding to the lighing volume and volumetric lighting tasks

… framegraph-volumetric-lighting

bjsplat · 2025-11-27T18:37:52Z

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

bjsplat · 2025-11-27T18:45:29Z

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

bjsplat · 2025-11-27T18:59:28Z

Snapshot stored with reference name:
refs/pull/17515/merge

Test environment:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17515/merge/index.html

To test a playground add it to the URL, for example:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17515/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/17515/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/17515/merge
https://gui.babylonjs.com/?snapshot=refs/pull/17515/merge
https://nme.babylonjs.com/?snapshot=refs/pull/17515/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/17515/merge#BCU1XR#0

bjsplat · 2025-11-27T19:04:16Z

Interaction tests

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17515/merge/testResults/interactionplaywright/index.html

bjsplat · 2025-11-27T19:11:01Z

Devhost visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17515/merge/testResults/devhostplaywright/index.html

bjsplat · 2025-11-27T19:14:22Z

Visualization tests for WebGPU

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17515/merge/testResults/webgpuplaywright/index.html

bjsplat · 2025-11-27T19:16:48Z

WebGL2 visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17515/merge/testResults/webgl2playwright/index.html

packages/dev/core/src/States/IStencilState.ts

bjsplat · 2025-11-27T20:28:07Z

Interaction tests

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17515/merge/testResults/interactionplaywright/index.html

bjsplat · 2025-11-27T20:28:31Z

Devhost visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17515/merge/testResults/devhostplaywright/index.html

bjsplat · 2025-11-27T20:35:48Z

Visualization tests for WebGPU

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17515/merge/testResults/webgpuplaywright/index.html

bjsplat · 2025-11-27T20:37:36Z

WebGL2 visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17515/merge/testResults/webgl2playwright/index.html

Popov72 · 2025-11-27T20:50:43Z

WebGL visu test generates this error:

 ANGLE (Apple, ANGLE Metal Renderer: Apple M1, Unspecified Version)
Running test: FrameGraph volumetric lighting . Meta:  #3VH0AC
[FrameGraph volumetric lighting] [.WebGL-0x13c00424e00] GL_INVALID_OPERATION: glDrawElements: It is undefined behaviour to have a used but unbound uniform buffer.
[FrameGraph volumetric lighting] [.WebGL-0x13c00424e00] GL_INVALID_OPERATION: glDrawElements: It is undefined behaviour to have a used but unbound uniform buffer.

I have no idea why it fails, as it works locally in all browsers I tested (Chrome, Firefox, Edge). So, I'm just disabling this test for WebGL2 for now.

bjsplat · 2025-11-27T21:17:24Z

Interaction tests

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17515/merge/testResults/interactionplaywright/index.html

bjsplat · 2025-11-27T21:20:19Z

Devhost visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17515/merge/testResults/devhostplaywright/index.html

bjsplat · 2025-11-27T21:24:26Z

WebGL2 visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17515/merge/testResults/webgl2playwright/index.html

sebavan · 2025-11-27T21:24:37Z

WebGL visu test generates this error:

 ANGLE (Apple, ANGLE Metal Renderer: Apple M1, Unspecified Version)
Running test: FrameGraph volumetric lighting . Meta:  #3VH0AC
[FrameGraph volumetric lighting] [.WebGL-0x13c00424e00] GL_INVALID_OPERATION: glDrawElements: It is undefined behaviour to have a used but unbound uniform buffer.
[FrameGraph volumetric lighting] [.WebGL-0x13c00424e00] GL_INVALID_OPERATION: glDrawElements: It is undefined behaviour to have a used but unbound uniform buffer.

I have no idea why it fails, as it works locally in all browsers I tested (Chrome, Firefox, Edge). So, I'm just disabling this test for WebGL2 for now.

Where you able to try on a mac ?

bjsplat · 2025-11-27T21:24:58Z

Visualization tests for WebGPU

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17515/merge/testResults/webgpuplaywright/index.html

Popov72 · 2025-11-27T23:51:07Z

WebGL visu test generates this error:
 ANGLE (Apple, ANGLE Metal Renderer: Apple M1, Unspecified Version)
Running test: FrameGraph volumetric lighting . Meta:  #3VH0AC
[FrameGraph volumetric lighting] [.WebGL-0x13c00424e00] GL_INVALID_OPERATION: glDrawElements: It is undefined behaviour to have a used but unbound uniform buffer.
[FrameGraph volumetric lighting] [.WebGL-0x13c00424e00] GL_INVALID_OPERATION: glDrawElements: It is undefined behaviour to have a used but unbound uniform buffer.
I have no idea why it fails, as it works locally in all browsers I tested (Chrome, Firefox, Edge). So, I'm just disabling this test for WebGL2 for now.
Where you able to try on a mac ?

No, I don't have a mac...

sebavan · 2025-11-28T07:10:17Z

WebGL visu test generates this error:
 ANGLE (Apple, ANGLE Metal Renderer: Apple M1, Unspecified Version)
Running test: FrameGraph volumetric lighting . Meta:  #3VH0AC
[FrameGraph volumetric lighting] [.WebGL-0x13c00424e00] GL_INVALID_OPERATION: glDrawElements: It is undefined behaviour to have a used but unbound uniform buffer.
[FrameGraph volumetric lighting] [.WebGL-0x13c00424e00] GL_INVALID_OPERATION: glDrawElements: It is undefined behaviour to have a used but unbound uniform buffer.
I have no idea why it fails, as it works locally in all browsers I tested (Chrome, Firefox, Edge). So, I'm just disabling this test for WebGL2 for now.
Where you able to try on a mac ?
No, I don't have a mac...

I ll try today as i wonder if this is our special mode to disable ubo or smthg similar there.

bjsplat · 2025-11-28T16:10:40Z

Graph tools CI has failed you can find the test results at:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/TOOLS/refs/pull/17515/merge/testResults/

bjsplat · 2025-11-28T17:09:10Z

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

bjsplat · 2025-11-28T17:12:01Z

Graph tools CI has failed you can find the test results at:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/TOOLS/refs/pull/17515/merge/testResults/

bjsplat · 2025-11-28T17:15:33Z

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

bjsplat · 2025-11-28T17:33:06Z

Snapshot stored with reference name:
refs/pull/17515/merge

Test environment:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17515/merge/index.html

To test a playground add it to the URL, for example:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17515/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/17515/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/17515/merge
https://gui.babylonjs.com/?snapshot=refs/pull/17515/merge
https://nme.babylonjs.com/?snapshot=refs/pull/17515/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/17515/merge#BCU1XR#0

bjsplat · 2025-11-28T17:35:39Z

You have made possible changes to one or more graph tools. To test the snapshots:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/TOOLS/refs/pull/17515/merge/nodeEditor/
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/TOOLS/refs/pull/17515/merge/nodeGeometryEditor/
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/TOOLS/refs/pull/17515/merge/nodeRenderGraphEditor/
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/TOOLS/refs/pull/17515/merge/guiEditor/

bjsplat · 2025-11-28T17:39:15Z

Interaction tests

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17515/merge/testResults/interactionplaywright/index.html

bjsplat · 2025-11-28T17:40:49Z

Devhost visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17515/merge/testResults/devhostplaywright/index.html

bjsplat · 2025-11-28T17:46:31Z

WebGL2 visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17515/merge/testResults/webgl2playwright/index.html

bjsplat · 2025-11-28T17:48:54Z

Visualization tests for WebGPU

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17515/merge/testResults/webgpuplaywright/index.html

Popov72 added 7 commits November 25, 2025 18:14

Add new LightingVolume class

2ca3ff1

Merge branch 'master' of https://github.com/BabylonJS/Babylon.js into…

0cce42c

… framegraph-volumetric-lighting

Fix crash when depth/stencil attachment has no depth

54ab21c

Refactor IStencilState

9ffb133

Fix wrong error message when disabled pass is not a render pass

1f9322d

Fix crash in WebGL when updating the buildFullVolume property

0409729

Add new volumetric lighting class to frame graphs

677e9d6

Popov72 added new feature frame graph labels Nov 27, 2025

Update visu test

7796b71

Update visu test

7071f2f

sebavan reviewed Nov 27, 2025

View reviewed changes

packages/dev/core/src/States/IStencilState.ts Show resolved Hide resolved

Disable visu test for WebGL

a00f72c

sebavan enabled auto-merge (squash) November 27, 2025 22:15

Add the NRG blocks for lighting volume and volumetric lighting

af84939

Fix visu test in WebGL

614696e

Fix ts

d48872a

sebavan approved these changes Nov 28, 2025

View reviewed changes

sebavan merged commit 9e365f3 into BabylonJS:master Nov 28, 2025
20 checks passed

FrameGraph: add new volumetric lighting task #17515

FrameGraph: add new volumetric lighting task #17515

Conversation

Popov72 commented Nov 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bjsplat commented Nov 27, 2025

Uh oh!

bjsplat commented Nov 27, 2025

Uh oh!

bjsplat commented Nov 27, 2025

Uh oh!

bjsplat commented Nov 27, 2025

Uh oh!

bjsplat commented Nov 27, 2025

Uh oh!

bjsplat commented Nov 27, 2025

Uh oh!

bjsplat commented Nov 27, 2025

Uh oh!

Uh oh!

bjsplat commented Nov 27, 2025

Uh oh!

bjsplat commented Nov 27, 2025

Uh oh!

bjsplat commented Nov 27, 2025

Uh oh!

bjsplat commented Nov 27, 2025

Uh oh!

Popov72 commented Nov 27, 2025

Uh oh!

bjsplat commented Nov 27, 2025

Uh oh!

bjsplat commented Nov 27, 2025

Uh oh!

bjsplat commented Nov 27, 2025

Uh oh!

sebavan commented Nov 27, 2025

Uh oh!

bjsplat commented Nov 27, 2025

Uh oh!

Popov72 commented Nov 27, 2025

Uh oh!

sebavan commented Nov 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bjsplat commented Nov 28, 2025

Uh oh!

bjsplat commented Nov 28, 2025

Uh oh!

bjsplat commented Nov 28, 2025

Uh oh!

bjsplat commented Nov 28, 2025

Uh oh!

bjsplat commented Nov 28, 2025

Uh oh!

bjsplat commented Nov 28, 2025

Uh oh!

bjsplat commented Nov 28, 2025

Uh oh!

bjsplat commented Nov 28, 2025

Uh oh!

bjsplat commented Nov 28, 2025

Uh oh!

bjsplat commented Nov 28, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Popov72 commented Nov 27, 2025 •

edited

Loading

sebavan commented Nov 28, 2025 •

edited

Loading